Review main Merged

61218[BUGFIX] Always provide default language

Andreas Kienast CR +2 V +2 Normal +60 −0 updated 07/05/19, 14:40

Commit message

The TranslationConfigurationProvider should always provide the default
language, even if the backend user doesn't have permissions configured.

This is due to the fact that some actions always require the presence
of the default language. This is a regression introduced with sites.

This patch always adds the default languages, as it was with pseudo
sites in place.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1417

  1. Andreas Kienast uploaded patch set 1 07/03/19, 14:05

  2. TYPO3com voted on patch set 1 V +1 07/03/19, 14:15 Completed build in 09m 58s on Wed, 3 Jul, 04:15 PM Test Summary: 46840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34738

  3. Benni Mack voted on patch set 1 V +1 CR +1 07/03/19, 14:33

  4. Oliver Klee commented on patch set 1 07/03/19, 15:37

    Can we have a regression test for this issues?
  5. Andreas Kienast commented on patch set 1 07/03/19, 17:01

    > Patch Set 1: > > Can we have a regression test for this issues? Sure. I hope the following test is already enough.
  6. Andreas Kienast uploaded patch set 2 07/03/19, 17:01

  7. Andreas Kienast uploaded patch set 3 07/03/19, 17:03

  8. TYPO3com voted on patch set 2 V +1 07/03/19, 17:13 Completed build in 11m 44s on Wed, 3 Jul, 07:13 PM Test Summary: 46844 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34756

  9. TYPO3com voted on patch set 3 V +1 07/03/19, 17:15 Completed build in 11m 41s on Wed, 3 Jul, 07:15 PM Test Summary: 46843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34757

  10. Oliver Klee voted on patch set 3 CR +1 07/03/19, 18:08

  11. Oliver Klee commented on patch set 3 07/03/19, 18:08

    Nice!
  12. Georg Ringer voted on patch set 3 CR +1 07/04/19, 06:39

  13. Frank Nägler voted on patch set 3 V +1 CR +1 07/05/19, 13:37

  14. Anja Leichsenring commented on patch set 3 V -1 CR +2 07/05/19, 13:48

    testing in progress
  15. Daniel Goerz voted on patch set 3 CR +1 07/05/19, 14:30

  16. Anja Leichsenring voted on patch set 3 V +2 07/05/19, 14:40

  17. Anja Leichsenring merged patch set 4 07/05/19, 14:40