61225[TASK] Respect requirements in ExtbasePluginEnhancer
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 2
Review log 1930
Show 25 earlier messages
-
TYPO3com uploaded patch set 1 07/04/19, 06:01
-
TYPO3com voted on patch set 1 V +1 07/04/19, 06:11 Completed build in 10m 09s on Thu, 4 Jul, 08:11 AM Test Summary: 46840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34762
-
Oliver Klee commented on patch set 1 07/04/19, 10:35
Can we have tests for this? And is 9.5 affected as well? -
Kalle Karlson commented on patch set 2 07/05/19, 08:41
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V -1 07/05/19, 08:41 Completed build in 14s on Fri, 5 Jul, 10:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34788
-
Kalle Karlson commented on patch set 3 07/05/19, 08:48
Published edit on patch set 2. -
Kalle Karlson commented on patch set 4 07/05/19, 08:57
Published edit on patch set 3. -
TYPO3com voted on patch set 3 V +1 07/05/19, 08:59 Completed build in 10m 32s on Fri, 5 Jul, 10:59 AM Test Summary: 46704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34789
-
Kalle Karlson commented on patch set 4 07/05/19, 09:01
9.5 is affected as well. -
TYPO3com voted on patch set 4 V +1 07/05/19, 09:09 Completed build in 11m 50s on Fri, 5 Jul, 11:09 AM Test Summary: 46704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34790
-
Oliver Klee updated the commit message in patch set 5 07/05/19, 10:55
-
Oliver Klee updated the commit message in patch set 6 07/05/19, 10:56
-
TYPO3com voted on patch set 5 V +1 07/05/19, 11:09 Completed build in 13m 16s on Fri, 5 Jul, 01:09 PM Test Summary: 46704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34797
-
TYPO3com voted on patch set 6 V +1 07/05/19, 11:14 Completed build in 18m 19s on Fri, 5 Jul, 01:14 PM Test Summary: 46704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34798
-
Anja Leichsenring updated the commit message in patch set 7 07/05/19, 12:41
-
TYPO3com voted on patch set 7 V -1 07/05/19, 12:51 Completed build in 10m 14s on Fri, 5 Jul, 02:51 PM Test Summary: 21 of 47067 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34806
-
TYPO3com voted on patch set 7 V +1 07/05/19, 13:31 Completed build in 1h 00m 02s on Fri, 5 Jul, 03:31 PM Test Summary: 46704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34806
-
Daniel Windloff commented on patch set 7 07/05/19, 13:38
ExtbasePluginEnhancer.php:96From code comparison to PluginEnhancer->getVariant, I would propose to use $route->setRequirements($namespacedRequirements); first. As far as I see the requirements configuration should be analog. -
Oliver Klee wrote 07/05/19, 13:49
Removed reviewer Oliver Klee. -
Kalle Karlson commented on patch set 8 07/09/19, 06:26
Published edit on patch set 7. -
TYPO3com voted on patch set 8 V -1 07/09/19, 06:26 Completed build in 12s on Tue, 9 Jul, 08:26 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34851
-
Kalle Karlson commented on patch set 9 07/09/19, 06:29
Published edit on patch set 8. -
TYPO3com voted on patch set 9 V +1 07/09/19, 06:41 Completed build in 11m 33s on Tue, 9 Jul, 08:41 AM Test Summary: 46738 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34852
-
Kalle Karlson commented on patch set 9 07/12/19, 11:45
ExtbasePluginEnhancer.php:96Reply Unresolved$namespacedRequirements didn't return the same as $this->deflateParameters(). in $namespacedRequirements are only the cleartext vars not the compiled vars, so there is no matching possible. -
Oliver Hader commented on patch set 9 10/26/19, 08:14
→ might be solved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/60361 as well, which consideres `default` and `requirement` -
Francois Suter commented on patch set 9 01/08/20, 10:58
I agree that https://review.typo3.org/c/Packages/TYPO3.CMS/+/60361 is the better answer. -
Oliver Hader marked it work in progress 01/13/20, 12:33
-
Oliver Hader commented on patch set 9 01/23/20, 10:49
Please continue at → https://review.typo3.org/q/Ia260e407dcc657a2e7c85628da9e001d94952c37 I like the additional enhancer tests of this change and would extend them for types Simple and Plugin as well... -
Oliver Hader wrote 01/23/20, 10:50
Assignee added: Oliver Hader <oliver.hader@typo3.org> -
Oliver Hader abandoned the change 02/17/20, 23:42