Review main Merged

61232[BUGFIX] Multi-selection mode in List module

Daniel Windloff CR +2 V +2 Easy +2 −0 updated 07/05/19, 16:32

Commit message

$GLOBALS['SOBE'] is still used in DatabaseRecordList.

Regression from
https://review.typo3.org/c/Packages/TYPO3.CMS/+/59357

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 1420

  1. Daniel Windloff uploaded patch set 1 07/05/19, 07:05

  2. TYPO3com voted on patch set 1 V +1 07/05/19, 07:15 Completed build in 09m 51s on Fri, 5 Jul, 09:15 AM Test Summary: 46700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34782

  3. Andreas Kienast updated the commit message in patch set 2 07/05/19, 07:49

  4. Andreas Kienast voted on patch set 2 V +1 CR +1 07/05/19, 07:49

  5. TYPO3com voted on patch set 2 V +1 07/05/19, 08:00 Completed build in 11m 17s on Fri, 5 Jul, 10:00 AM Test Summary: 46700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34784

  6. Frank Nägler commented on patch set 2 CR -1 07/05/19, 14:20

    on it
  7. Frank Nägler updated the commit message in patch set 3 07/05/19, 14:25

  8. Frank Nägler voted on patch set 3 CR +1 07/05/19, 14:25

  9. Frank Nägler updated the commit message in patch set 4 07/05/19, 14:25

  10. Frank Nägler voted on patch set 4 CR +1 07/05/19, 14:26

  11. Oliver Klee commented on patch set 4 07/05/19, 14:31

    RecordListController.php:305

    Should we have the same comment here as further down?
  12. TYPO3com voted on patch set 3 V +1 07/05/19, 14:36 Completed build in 11m 15s on Fri, 5 Jul, 04:36 PM Test Summary: 46700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34815

  13. TYPO3com voted on patch set 4 V -1 07/05/19, 14:38 Completed build in 11m 59s on Fri, 5 Jul, 04:38 PM Test Summary: 21 of 47063 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34816

  14. TYPO3com voted on patch set 4 V +1 07/05/19, 14:48 Completed build in 34m 14s on Fri, 5 Jul, 04:48 PM Test Summary: 46700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34816

  15. Daniel Windloff uploaded patch set 5 07/05/19, 14:54

  16. Daniel Windloff commented on patch set 5 07/05/19, 14:56

    RecordListController.php:305 Reply

    Is removed. List module still works with one assignment.
  17. Andreas Kienast voted on patch set 5 V +1 CR +1 07/05/19, 15:02

  18. TYPO3com voted on patch set 5 V +1 07/05/19, 15:05 Completed build in 11m 02s on Fri, 5 Jul, 05:05 PM Test Summary: 46704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34818

  19. Daniel Goerz voted on patch set 5 V +2 CR +2 07/05/19, 16:32

  20. Daniel Goerz merged patch set 6 07/05/19, 16:32