61237[BUGFIX] Adjust EmailFinisher to new recipient style
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Susi Moog uploaded patch set 1 07/08/19, 14:28
-
TYPO3com voted on patch set 1 V +1 07/08/19, 14:41 Completed build in 12m 30s on Mon, 8 Jul, 04:41 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34844
-
Oliver Klee commented on patch set 1 07/08/19, 15:34
Can we have tests for this? -
Susi Moog commented on patch set 1 07/08/19, 16:14
@oliver would you mind adding some? the change should have tests, however it will take some time until I can do it properly - I just needed the feature fixed for a presentation ;) -
Anja Leichsenring voted on patch set 1 V +1 CR +1 07/08/19, 18:47
-
Benjamin Franzke uploaded patch set 2 07/08/19, 21:56
-
Benjamin Franzke commented on patch set 1 07/08/19, 21:56
EmailFinisher.php:288NamedAdress can handle empty $name strings just fine, therefore I think it would be ok to use NamedAdress always. We do the same in $mail->from as well, where the name could be an empty string as well.EmailFinisher.php:291This performs the same check is in the previous array_filter, we could/should merge this. -
Benjamin Franzke voted on patch set 2 V +1 CR +1 07/08/19, 21:57
-
TYPO3com voted on patch set 2 V +1 07/08/19, 22:09 Completed build in 12m 58s on Tue, 9 Jul, 12:09 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34850
-
Jörg Bösche commented on patch set 2 07/09/19, 07:12
EmailFinisher.php:288ReplyDoneEmailFinisher.php:291ReplyDone -
Oliver Klee commented on patch set 2 07/09/19, 10:00
> would you mind adding some? I'd like to, but at the moment, I'm too busy in other projects. -
Benni Mack voted on patch set 2 V +2 CR +2 07/09/19, 13:18
-
Benni Mack merged patch set 3 07/09/19, 13:18