Review main Merged

61237[BUGFIX] Adjust EmailFinisher to new recipient style

Susi Moog CR +2 V +2 Easy +12 −9 updated 07/09/19, 13:18

Commit message

With the symfony mail component recipient addresses should be
instantiated and used as either `Address` or `NamedAddress` object
instead of an associative array. The patch introduces usage of both.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Susi Moog uploaded patch set 1 07/08/19, 14:28

  2. TYPO3com voted on patch set 1 V +1 07/08/19, 14:41 Completed build in 12m 30s on Mon, 8 Jul, 04:41 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34844

  3. Oliver Klee commented on patch set 1 07/08/19, 15:34

    Can we have tests for this?
  4. Susi Moog commented on patch set 1 07/08/19, 16:14

    @oliver would you mind adding some? the change should have tests, however it will take some time until I can do it properly - I just needed the feature fixed for a presentation ;)
  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 07/08/19, 18:47

  6. Benjamin Franzke uploaded patch set 2 07/08/19, 21:56

  7. Benjamin Franzke commented on patch set 1 07/08/19, 21:56

    EmailFinisher.php:288

    NamedAdress can handle empty $name strings just fine, therefore I think it would be ok to use NamedAdress always. We do the same in $mail->from as well, where the name could be an empty string as well.

    EmailFinisher.php:291

    This performs the same check is in the previous array_filter, we could/should merge this.
  8. Benjamin Franzke voted on patch set 2 V +1 CR +1 07/08/19, 21:57

  9. TYPO3com voted on patch set 2 V +1 07/08/19, 22:09 Completed build in 12m 58s on Tue, 9 Jul, 12:09 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34850

  10. Jörg Bösche commented on patch set 2 07/09/19, 07:12

    EmailFinisher.php:288 Reply

    Done

    EmailFinisher.php:291 Reply

    Done
  11. Oliver Klee commented on patch set 2 07/09/19, 10:00

    > would you mind adding some? I'd like to, but at the moment, I'm too busy in other projects.
  12. Benni Mack voted on patch set 2 V +2 CR +2 07/09/19, 13:18

  13. Benni Mack merged patch set 3 07/09/19, 13:18