61242[!!!][TASK] Extract CSV export from DatabaseRecordList
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 29
- typo3/sysext/core/Classes/Http/CsvResponse.php14new+93 −0
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88713-ExtractCsvExportFromDatabaseRecordList.rstnew+31 −0
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88713-FunctionalityRemovedFromDatabaseRecordList.rstnew+38 −0
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88713-RecordlistHooksToModifyCsvExportHaveBeenReplaced.rstnew+37 −0
- typo3/sysext/core/Resources/Private/Language/locallang_mod_web_list.xlf2+6 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+15 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+42 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+5 −0
- typo3/sysext/recordlist/Classes/Controller/CsvExportController.php4new+131 −0
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/recordlist/Classes/Event/RecordlistCustomizeCsvHeaderEvent.phpnew+75 −0
- typo3/sysext/recordlist/Classes/Event/RecordlistCustomizeCsvQueryEvent.phpnew+99 −0
- typo3/sysext/recordlist/Classes/Event/RecordlistCustomizeCsvRowEvent.phpnew+75 −0
- typo3/sysext/recordlist/Classes/RecordList/Access/CsvExportAccess.phpnew+228 −0
- typo3/sysext/recordlist/Classes/RecordList/CsvExport.php8new+146 −0
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php2+28 −163
- typo3/sysext/recordlist/Configuration/Backend/Routes.php+5 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Access/CsvExportAccessTest.phpnew+465 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/Extensions/csvexporttest/Configuration/TCA/tx_csvexporttest_nocrtlfields.phpnew+49 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/Extensions/csvexporttest/Configuration/TCA/tx_csvexporttest_nocrtlfields_hidden.phpnew+50 −0
Show 9 more files
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/Extensions/csvexporttest/Configuration/TCA/tx_csvexporttest_withcrtlfields.phpnew+77 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/Extensions/csvexporttest/ext_emconf.phpnew+19 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/Extensions/csvexporttest/ext_localconf.phpnew+1 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/Extensions/csvexporttest/ext_tables.sqlnew+26 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/be_groups.xmlnew+16 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/be_users.xmlnew+67 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/pages.xmlnew+104 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/Fixtures/tx_csvexporttest_withcrtlfields.xmlnew+71 −0
- typo3/sysext/recordlist/Tests/Functional/RecordList/CsvExportTest.phpnew+149 −0
Review log 5678
Show 3953 earlier messages
-
Daniel Windloff uploaded patch set 1 07/09/19, 14:08
-
TYPO3com voted on patch set 1 V +1 07/09/19, 14:18 Completed build in 09m 41s on Tue, 9 Jul, 04:18 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34865
-
Daniel Windloff uploaded patch set 2 07/10/19, 08:04
-
TYPO3com voted on patch set 2 V -1 07/10/19, 08:15 Completed build in 11m 02s on Wed, 10 Jul, 10:15 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34872
-
Daniel Windloff uploaded patch set 3 07/10/19, 10:29
-
TYPO3com voted on patch set 3 V -1 07/10/19, 10:29 Completed build in 13s on Wed, 10 Jul, 12:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34877
-
Daniel Windloff uploaded patch set 4 07/10/19, 10:31
-
TYPO3com voted on patch set 4 V +1 07/10/19, 10:42 Completed build in 11m 12s on Wed, 10 Jul, 12:42 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34878
-
Markus Klein updated the commit message in patch set 5 07/10/19, 10:45
-
Markus Klein commented on patch set 5 07/10/19, 10:48
CsvResponse.php:32please document the expected structure of $data here somewhere -
Markus Klein commented on patch set 5 07/10/19, 10:50
AccessUtility.php:172same hereAccessUtility.php:196superfluous, inList returns already a boolAccessUtility.php:211lets stick to using the ! operator for this? -
Guido Schmechel commented on patch set 5 07/10/19, 10:53
DatabaseRecordList.php:847Duplicate Code. Can refactor into an own methodCsvExportTest.php:2Maybe declare_strict?CsvExportTest.php:3Typo. ReordList (Missing c)CsvExportTest.php:28Is this correct? -
Guido Schmechel commented on patch set 5 07/10/19, 10:57
CsvResponse.php:92Maybe a bit more detailed? "Can not create the CSV because $data is not an array." -
TYPO3com voted on patch set 5 V +1 07/10/19, 10:57 Completed build in 11m 26s on Wed, 10 Jul, 12:57 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34879
-
Daniel Windloff uploaded patch set 6 07/10/19, 12:05
-
Daniel Windloff uploaded patch set 7 07/10/19, 12:08
-
Daniel Windloff commented on patch set 7 07/10/19, 12:17
CsvResponse.php:2ReplyDoneCsvResponse.php:32ReplyDoneCsvResponse.php:92ReplyI have removed the exception, because $data must always be an array (typehint)DatabaseRecordList.php:847ReplyDoneAccessUtility.php:172Reply Unresolvedsee other commentAccessUtility.php:196ReplyDoneAccessUtility.php:211Reply UnresolvedI prefer the "=== false" way of writing as I think it better to read. (But I know, it is much longer. ;))CsvExportTest.php:2ReplyDoneCsvExportTest.php:3ReplyDoneCsvExportTest.php:28Reply UnresolvedYes, I think so. I'd like to load a test extension to test against tca settings. -
TYPO3com voted on patch set 6 V +1 07/10/19, 12:18 Completed build in 12m 57s on Wed, 10 Jul, 02:18 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34883
-
TYPO3com voted on patch set 7 V +1 07/10/19, 12:19 Completed build in 10m 26s on Wed, 10 Jul, 02:19 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34884
-
Jörg Bösche commented on patch set 7 07/10/19, 14:03
CsvResponse.php:73return type: selflocallang_mod_web_list.xlf:178Unnecessary white space at the end of value.CsvExportController.php:88Import the FQDN to use section.CsvExportController.php:110add strict return typeCsvExport.php:156add strict return type -
Daniel Windloff uploaded patch set 8 07/10/19, 14:21
-
Daniel Windloff commented on patch set 8 07/10/19, 14:22
CsvResponse.php:73ReplyDonelocallang_mod_web_list.xlf:178ReplyDoneCsvExportController.php:88ReplyDoneCsvExportController.php:110ReplyDoneCsvExport.php:156ReplyDone -
TYPO3com voted on patch set 8 V +1 07/10/19, 14:33 Completed build in 12m 23s on Wed, 10 Jul, 04:33 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34890
-
Markus Klein commented on patch set 8 07/12/19, 09:44
Extract CSV export from DatabaseRecordList -
Markus Klein updated the commit message in patch set 9 07/12/19, 09:44
-
TYPO3com voted on patch set 9 V +1 07/12/19, 09:59 Completed build in 14m 45s on Fri, 12 Jul, 11:59 AM Test Summary: 46978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34950
-
Daniel Windloff commented on patch set 9 07/12/19, 11:03
Reply
Ack -
Jörg Bösche voted on patch set 9 V +1 CR +1 07/12/19, 12:01
-
Tobi Kretschmann uploaded patch set 10 07/12/19, 12:30
-
TYPO3com voted on patch set 10 V +1 07/12/19, 12:46 Completed build in 12m 51s on Fri, 12 Jul, 02:46 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34964
-
Jörg Bösche voted on patch set 10 V +1 CR +1 07/12/19, 12:52
-
Tobi Kretschmann voted on patch set 10 V +2 CR +2 07/12/19, 13:14
-
Tobi Kretschmann voted on patch set 10 V +1 CR +1 07/12/19, 16:31
-
Daniel Windloff uploaded patch set 11 07/14/19, 08:04
-
TYPO3com voted on patch set 11 V +1 07/14/19, 08:15 Completed build in 10m 35s on Sun, 14 Jul, 10:15 AM Test Summary: 47002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35018
-
Daniel Windloff commented on patch set 11 07/14/19, 08:15
Just resolved merge conflict. -
Daniel Windloff uploaded patch set 12 07/19/19, 11:07
-
Daniel Windloff commented on patch set 12 07/19/19, 11:09
Resolved merge conflict. -
Jörg Bösche voted on patch set 12 V +1 CR +1 07/19/19, 11:11
-
TYPO3com voted on patch set 12 V +1 07/19/19, 11:18 Completed build in 10m 34s on Fri, 19 Jul, 01:18 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35202
-
Daniel Windloff uploaded patch set 13 07/19/19, 11:25
-
Daniel Windloff uploaded patch set 14 07/19/19, 11:27
-
Frank Nägler voted on patch set 14 V +1 CR +1 07/19/19, 11:27
-
Daniel Windloff commented on patch set 14 07/19/19, 11:28
fixed typos -
TYPO3com voted on patch set 13 V +1 07/19/19, 11:40 Completed build in 12m 52s on Fri, 19 Jul, 01:40 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35205
-
TYPO3com voted on patch set 14 V +1 07/19/19, 11:45 Completed build in 18m 11s on Fri, 19 Jul, 01:45 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35206
-
Benni Mack commented on patch set 14 07/19/19, 11:51
CsvResponse.php:23I doubt that ;)CsvResponse.php:27For one use case, do we really need a separate response class then?CsvExport.php:27Unresolvedplease mark this API internal.CsvExport.php:70the hooks will break. so if we want to remove the hooks in the old place, let's introduce new PSR-14 Events instead.AccessUtility.php:27that's a weird class... It somehow seems to be a TcaUserPermission functionality. I wonder if we could make it non-static, and have BE_User injected as constructor argument instead. -
Benni Mack voted on patch set 14 CR -1 07/19/19, 11:51
-
Daniel Windloff uploaded patch set 15 07/19/19, 12:13
-
Daniel Windloff commented on patch set 15 07/19/19, 12:15
CsvResponse.php:23ReplyDoneCsvResponse.php:27Reply UnresolvedEXT:core/Classes/Database/QueryView.php:551 also exports a csv and could use it in the future.CsvExport.php:70ReplyI don't get it, why the hook should break. I do not modify the hook name: DatabaseRecordList::class. I'll have a look at PSR-14 as replacement. At the time of the writing, this was not merged ;)AccessUtility.php:27Reply UnresolvedThe intension of this class was to extract a lot of access checks to exable functional tests on user permissons. I'm fine with making this class non static. But I would like to let the BackendUser as argument to make the functional testing better to read. -
Daniel Windloff uploaded patch set 16 07/19/19, 12:36
-
Daniel Windloff uploaded patch set 17 07/19/19, 12:44
-
Benni Mack commented on patch set 17 07/19/19, 13:46
CsvExport.php:70Replyyou hand in $this in callUserFunction - $this is now something else.
-
Daniel Windloff uploaded patch set 18 07/19/19, 14:43
-
TYPO3com voted on patch set 18 V +1 07/19/19, 14:55 Completed build in 11m 38s on Fri, 19 Jul, 04:55 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35226
-
Daniel Windloff uploaded patch set 19 07/19/19, 15:25
-
TYPO3com voted on patch set 19 V +1 07/19/19, 15:37 Completed build in 11m 08s on Fri, 19 Jul, 05:37 PM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35232
-
Daniel Windloff uploaded patch set 20 07/20/19, 06:08
-
TYPO3com voted on patch set 20 V +1 07/20/19, 06:20 Completed build in 11m 47s on Sat, 20 Jul, 08:20 AM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35237
-
Daniel Windloff commented on patch set 20 07/22/19, 07:19
CsvExport.php:70Reply UnresolvedUse new api and modified breaking doc -
Georg Ringer voted on patch set 20 V +1 CR +1 07/22/19, 07:44
-
Tymoteusz Motylewski commented on patch set 20 07/22/19, 21:11
CsvResponse.php:58UnresolvedIs that correct? I mean the string containing two quotes as a header value? -
Daniel Windloff uploaded patch set 21 07/29/19, 11:20
-
Daniel Windloff commented on patch set 21 07/29/19, 11:21
Resolve merge conflict. -
TYPO3com voted on patch set 21 V +1 07/29/19, 11:30 Completed build in 10m 08s on Mon, 29 Jul, 01:30 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35363
-
Anja Leichsenring uploaded patch set 22 09/25/19, 12:16
-
TYPO3com voted on patch set 22 V +1 09/25/19, 12:26 Completed build in 10m 10s on Wed, 25 Sep, 12:26 PM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36810
-
Anja Leichsenring uploaded patch set 23 09/25/19, 12:37
-
Anja Leichsenring commented on patch set 23 V -1 09/25/19, 12:38
this is possible without being breaking, just needs some love. I hope I can do that anytime soon. -
TYPO3com voted on patch set 23 V +1 09/25/19, 12:51 Completed build in 11m 40s on Wed, 25 Sep, 12:51 PM Test Summary: 47748 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36812
-
Daniel Siepmann uploaded patch set 24 09/27/19, 13:55
-
TYPO3com voted on patch set 24 V +1 09/27/19, 14:06 Completed build in 11m 32s on Fri, 27 Sep, 02:06 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36896
-
Markus Klein updated the commit message in patch set 25 09/27/19, 14:35
-
Markus Klein commented on patch set 25 09/27/19, 14:38
CsvResponse.php:57Unresolvedthis should be configurable somehow. for instance for MS excel we need a windows or latin charset! Or, to turn the question around: are we sure the data is really encoded like this? -
TYPO3com voted on patch set 25 V +1 09/27/19, 14:45 Completed build in 10m 13s on Fri, 27 Sep, 02:45 PM Test Summary: 47716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36903
-
Benni Mack commented on patch set 25 01/27/20, 15:29
I'll abandon this patch for now. It does WAY too much currently. We should split this in separate parts: - Provide a generic CSV Export route for exporting a TCA Table selection as a new Feature - Have Database Record List use the new CSV Export and deprecate the old options -
Benni Mack abandoned the change 01/27/20, 15:29
CsvResponse.php:2