61243[BUGFIX] Respect ctrl|readOnly in record list
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Guido Schmechel +1
- Julian Geils +1
-
Verified V +2 Done
- Benni Mack +2
- Julian Geils +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1418
-
Georg Ringer uploaded patch set 1 07/10/19, 06:53
-
TYPO3com voted on patch set 1 V +1 07/10/19, 07:03 Completed build in 09m 43s on Wed, 10 Jul, 09:03 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34870
-
Stefan P commented on patch set 1 07/10/19, 07:40
if ($GLOBALS['TCA'][$table]['ctrl']['readOnly'] && $GLOBALS['TCA'][$table]['ctrl']['readOnly']) This is the same condition twice, isn't it? -
Julian Geils uploaded patch set 2 07/10/19, 09:25
-
Georg Ringer commented on patch set 2 07/10/19, 09:29
This change is ready for review. -
TYPO3com voted on patch set 2 V +1 07/10/19, 09:37 Completed build in 11m 46s on Wed, 10 Jul, 11:37 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34874
-
Markus Klein commented on patch set 2 07/10/19, 10:06
DatabaseRecordList.php:2865we should use !empty() here, because readOnly might not be set -
Steffen Frese uploaded patch set 3 07/10/19, 12:27
-
Steffen Frese commented on patch set 3 07/10/19, 12:29
added !empty check like requested. also added scalar types for isEditableDatabaseRecordList.php:2865ReplyDone -
Steffen Frese uploaded patch set 4 07/10/19, 12:38
-
TYPO3com voted on patch set 3 V +1 07/10/19, 12:39 Completed build in 11m 39s on Wed, 10 Jul, 02:39 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34885
-
Julian Geils commented on patch set 4 07/10/19, 12:39
this bug only occurs in the v9.5 at the current master its already fixed. but in v9.5 this patch solve the problem. -
TYPO3com voted on patch set 4 V +1 07/10/19, 12:51 Completed build in 12m 37s on Wed, 10 Jul, 02:51 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34887
-
Julian Geils voted on patch set 4 V +1 CR +1 07/10/19, 12:55
-
Markus Klein voted on patch set 4 CR +1 07/10/19, 16:14
-
Guido Schmechel voted on patch set 4 CR +1 07/13/19, 08:17
-
Benni Mack voted on patch set 4 V +2 CR +2 07/14/19, 08:48
-
Benni Mack merged patch set 5 07/14/19, 08:48