Review main Merged

61245[TASK] Invoke "Clear Page cache" in page and list module via ajax

Daniel Windloff CR +2 V +2 Hard +210 −54 updated 07/12/19, 08:36

Commit message

* Add a message for the user
* Adjust context menu to new route
* Split functionality in an own controller class

Review

  • Code review CR +2 Done
    • Tobi Kretschmann +2
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Tobi Kretschmann +2
    • Jörg Bösche +1
    • Steffen Frese +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 78

  1. Daniel Windloff uploaded patch set 1 07/11/19, 07:35

  2. TYPO3com voted on patch set 1 V +1 07/11/19, 07:50 Completed build in 15m 10s on Thu, 11 Jul, 09:50 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34896

  3. Steffen Frese commented on patch set 1 V +1 07/11/19, 07:50

    DatabaseRecordList.php:708

    I think we should not use an <a> tag for this anymore. The system help button is just a styled <span> for example.
  4. Daniel Windloff commented on patch set 1 07/11/19, 08:00

    DatabaseRecordList.php:708 Reply

    I had a accessibility review recently and they forced me to set listeners of js based actions in "a" or "button" tags. So I would prefer to not change it to span.
  5. Steffen Frese commented on patch set 1 CR +1 07/11/19, 08:03

    DatabaseRecordList.php:708 Reply

    Ack
  6. Jörg Bösche commented on patch set 1 V +1 CR +1 07/12/19, 08:22

    Tested with master (10-dev). Attached a screenshot for better testing with the backend and affected buttons to test. See original forge issue.
  7. Tobi Kretschmann voted on patch set 1 V +2 CR +2 07/12/19, 08:30

  8. Tobi Kretschmann merged patch set 2 07/12/19, 08:36