Review main Abandoned

61247[FEATURE] Simplify non_exclude_field handling for backend groups

Georg Ringer CR 0 V 0 Normal +166 −14 updated 10/19/21, 19:00

Commit message

The field `non_exclude_fields` of the table `be_groups` has been changed to only
show fields of tables which either have been enabled in
the field `table_select` or `table_modify`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 9

Review log 2535

Show 710 earlier messages
  1. Georg Ringer uploaded patch set 1 07/11/19, 12:25

  2. TYPO3com voted on patch set 1 V -1 07/11/19, 12:27 Completed build in 44s on Thu, 11 Jul, 02:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34913

  3. Georg Ringer uploaded patch set 2 07/11/19, 12:29

  4. TYPO3com voted on patch set 2 V -1 07/11/19, 13:00 Completed build in 02m 16s on Thu, 11 Jul, 03:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34916

  5. Georg Ringer uploaded patch set 3 07/17/19, 07:59

  6. Georg Ringer commented on patch set 3 07/17/19, 08:00

    This change is ready for review.
  7. TYPO3com voted on patch set 3 V -1 07/17/19, 08:09 Completed build in 10m 03s on Wed, 17 Jul, 10:09 AM Test Summary: 23 of 47481 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35119

  8. Oliver Klee commented on patch set 3 07/17/19, 09:30

    SelectCheckBoxNonExcludeFieldsElement.php:3

    Can we make this file strict?

    SelectCheckBoxNonExcludeFieldsElement.php:30

    : array
  9. Daniel Windloff commented on patch set 3 07/17/19, 09:42

    In general I think it it a good idea to simplify the access handling. I have one issue regarding the std work flow after the patch: 1) edit groups 2) add permissions for tables listing and tables modify 3) save 4) add permissions for non_exclude_fields The 4) save action was not needed before to set all needed access rights for one table, if you create new user groups.
  10. Daniel Windloff commented on patch set 3 07/17/19, 09:44

    > The 4) save action was not needed before to set all needed access rights for one table, if you create new user groups. Of course I mean 3) :)
  1. Georg Ringer uploaded patch set 4 07/17/19, 12:52

  2. Georg Ringer commented on patch set 4 07/17/19, 12:52

    SelectCheckBoxNonExcludeFieldsElement.php:3 Reply Unresolved

    not possible, interface

    SelectCheckBoxNonExcludeFieldsElement.php:30 Reply

    Done
  3. TYPO3com voted on patch set 4 V -1 07/17/19, 13:04 Completed build in 11m 48s on Wed, 17 Jul, 03:04 PM Test Summary: 23 of 47481 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35127

  4. Georg Ringer uploaded patch set 5 07/17/19, 18:47

  5. TYPO3com voted on patch set 5 V -1 07/17/19, 18:58 Completed build in 11m 05s on Wed, 17 Jul, 08:58 PM Test Summary: 3 of 47481 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35143

  6. Georg Ringer uploaded patch set 6 08/01/19, 11:49

  7. TYPO3com voted on patch set 6 V +1 08/01/19, 11:59 Completed build in 09m 46s on Thu, 1 Aug, 11:59 AM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35431

  8. Susi Moog voted on patch set 6 V +1 CR +1 08/01/19, 15:34

  9. Josef Glatz commented on patch set 6 08/01/19, 20:35

    The feature itself is really awesome. Do you think we can also add any notification after changing a check in listing/modify tables? Background: If I'm a TYPO3 beginner it feels not really intuitive, that I have to know to click save while editing. A simple improvement could be: show an alert if something is changed within listing/modify table like shown in the screenshot at https://forge.typo3.org/issues/88786#note-5. Something could be triggered via JS?
  10. Georg Ringer commented on patch set 6 CR -2 08/02/19, 13:44

    checking out other solutions, e.g. using JS only
  11. Anja Leichsenring wrote 09/09/19, 08:37

    Removed reviewer Anja Leichsenring.
  12. Benjamin Franzke wrote 09/10/19, 04:34

    Removed reviewer Benjamin Franzke.
  13. Susi Moog abandoned the change 01/25/20, 11:56

    as you can restore changes yourself and nothing happened here for the last few months, I'm closing the review now - feel free to continue your work at any time ;)
  14. Georg Ringer restored the change 09/10/20, 19:24

  15. Georg Ringer uploaded patch set 7 09/10/20, 19:30

  16. TYPO3com voted on patch set 7 V -1 09/10/20, 19:30 Completed build in 32s on Thu, 10 Sep, 07:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5517

  17. Georg Ringer voted on patch set 7 CR 0 09/10/20, 19:30

  18. Georg Ringer uploaded patch set 8 09/10/20, 20:11

  19. TYPO3com voted on patch set 8 V +1 09/10/20, 20:34 Completed build in 18m 18s on Thu, 10 Sep, 08:34 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5524

  20. Oliver Klee wrote 09/10/20, 22:27

    Removed reviewer Oliver Klee.
  21. Markus Klein updated the commit message in patch set 9 09/11/20, 07:33

  22. TYPO3com voted on patch set 9 V -1 09/11/20, 07:46 Completed build in 12m 27s on Fri, 11 Sep, 07:46 AM Test Summary: 72567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5529

  23. TYPO3com voted on patch set 9 V +1 09/11/20, 17:50 Completed build in 11m 32s on Fri, 11 Sep, 05:50 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5552

  24. Benni Mack commented on patch set 9 09/11/20, 20:28

    Hey, what do you think if we move the new FormDataProvider and the special=exclude into a simple ItemsProcFunc? This would reduce "magic" from FormEngine and we won't need the new FormDataProvider?
  25. Georg Ringer abandoned the change 10/19/21, 19:00

    abandoned, no interest