Review main Merged

61251[BUGFIX] Prevent separating HTML inline elements

Sebastian Klein CR +2 V +2 Easy +1 −1 updated 02/22/20, 18:11

Commit message

The softhyphen button in RTE CKEditor separates HTML inline elements.
If the softhyphen is inserted inside a link, it results in two
individual links with the ­ entity between.

This can already be examined in the source view of the RTE.

Furthermore, a ­ entity between two HTML tags will prevent the
browser to insert a hyphen at the position of the linebreak.

Setting the optional mode 'text' to the insertHtml event will prevent
this behaviour, as the inserted content will then inherit the styles
which are applied in the selected position.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Michael Telgkamp +1
    • Henning Liebe +1
    • Felix P. +1
  • Verified V +2 Done
    • Susi Moog +2
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1820

  1. Sebastian Klein uploaded patch set 1 07/11/19, 18:33

  2. TYPO3com voted on patch set 1 V +1 07/11/19, 18:45 Completed build in 11m 28s on Thu, 11 Jul, 08:45 PM Test Summary: 46978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34930

  3. Steffen Frese voted on patch set 1 CR +1 07/12/19, 08:13

  4. Steffen Frese voted on patch set 1 V +1 07/12/19, 08:37

  5. Steffen Frese commented on patch set 1 07/12/19, 08:41

    test: write long word press `ctrl` + `-` to insert softhypen. view source.
  6. Julian Geils voted on patch set 1 V +1 CR +1 07/12/19, 09:51

  7. Julian Geils commented on patch set 1 07/12/19, 09:52

    ** test: write long word make it bold and than press `ctrl` + `-` to insert softhypen. view source.
  8. Johannes Seipelt voted on patch set 1 V +1 CR +1 07/13/19, 20:05

  9. Riccardo De Contardi commented on patch set 1 V +1 07/14/19, 08:55

    tested on Master with the following inline tags: em, strong, a, sub, sup
  10. Josef Glatz commented on patch set 1 CR -2 08/07/19, 09:29

    I'll test it through to version 8 and will then merge it!
  11. Sebastian Klein uploaded patch set 2 12/03/19, 21:34

  12. TYPO3com voted on patch set 2 V +1 12/03/19, 21:41 Completed build in 07m 20s on Tue, 3 Dec, 09:41 PM Test Summary: 68637 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39087

  13. Michael Telgkamp voted on patch set 2 V +1 CR +1 12/04/19, 07:56

  14. Oli Bartsch voted on patch set 2 CR +1 12/04/19, 10:19

  15. Henning Liebe voted on patch set 2 CR +1 01/14/20, 11:40

  16. Felix P. voted on patch set 2 CR +1 01/14/20, 11:53

  17. Susi Moog commented on patch set 2 02/17/20, 16:35

    ping @Josef: will you continue here? if not, please remove your -2!
  18. Josef Glatz voted on patch set 2 CR 0 02/18/20, 06:48

  19. Susi Moog voted on patch set 2 V +2 CR +2 02/22/20, 18:11

  20. Susi Moog merged patch set 3 02/22/20, 18:11