Review 9.5 Merged

61252[BUGFIX] Always provide default language

Anja Leichsenring CR +2 V +2 Normal +75 −2 updated 07/05/19, 15:26

Commit message

The TranslationConfigurationProvider should always provide the default
language, even if the backend user doesn't have permissions configured.

This is due to the fact that some actions always require the presence
of the default language. This is a regression introduced with sites.

This patch always adds the default languages, as it was with pseudo
sites in place.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Anja Leichsenring commented on patch set 1 07/05/19, 14:40

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php
  2. TYPO3com voted on patch set 1 V -1 07/05/19, 14:40 Completed build in 11s on Fri, 5 Jul, 04:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-869

  3. Anja Leichsenring uploaded patch set 2 07/05/19, 14:55

  4. Anja Leichsenring commented on patch set 2 07/05/19, 14:56

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 07/05/19, 15:08 Completed build in 12m 53s on Fri, 5 Jul, 05:08 PM Test Summary: 50479 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-870

  6. Richard Haeser voted on patch set 2 CR +1 07/05/19, 15:19

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 07/05/19, 15:21

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 07/05/19, 15:26

  9. Anja Leichsenring merged patch set 3 07/05/19, 15:26