61273[BUGFIX] Render modal if form is invalid
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Jörg Bösche +1
-
Verified V +2 Done
- Frank Nägler +2
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 711
-
Andreas Kienast uploaded patch set 1 07/11/19, 19:09
-
Andreas Kienast uploaded patch set 2 07/11/19, 19:10
-
TYPO3com voted on patch set 1 V -1 07/11/19, 19:23 Completed build in 14m 07s on Thu, 11 Jul, 09:23 PM Test Summary: 46906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34933
-
TYPO3com voted on patch set 2 V -1 07/11/19, 19:25 Completed build in 14m 09s on Thu, 11 Jul, 09:25 PM Test Summary: 46906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34934
-
TYPO3com commented on patch set 2 07/12/19, 08:48 Completed build in 13h 51m 45s on Fri, 12 Jul, 10:48 AM Test Summary: 46906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34934
-
Frank Nägler commented on patch set 3 07/12/19, 08:51
Published edit on patch set 2. -
Frank Nägler voted on patch set 3 V +1 CR +1 07/12/19, 08:59
-
TYPO3com voted on patch set 3 V +1 07/12/19, 09:06 Completed build in 14m 36s on Fri, 12 Jul, 11:06 AM Test Summary: 46978 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34947
-
Jörg Bösche commented on patch set 3 V +1 CR +1 07/12/19, 12:19
How to verify: Go to page settings -> empty the title field -> click on "save" button. Without the patch no modal with error message is shown. With the patch, the modal with the message is shown. -
Frank Nägler voted on patch set 3 V +2 CR +2 07/12/19, 12:20
-
Frank Nägler merged patch set 4 07/12/19, 12:21