Review main Merged

61278[BUGFIX] Dispatch native `change` event in TBE_EDITOR.fieldChanged()

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 07/14/19, 10:57

Commit message

With #87324 some code of FormEngine was moved into separated modules. In
the very same patch, most of the code was rewritten to use native
JavaScript as much as possible. However, with this change,
`TBE_EDITOR.fieldChanged()` was partially broken as it uses jQuery's
`triggerHandler` method to trigger a specific event. Events that are
registered via jQuery's `on()` method work fine, but the approach is
incompatible with JavaScript's native `addEventListener()` introduced
in the mentioned change.

As a quick fix, `TBE_EDITOR.fieldChanged()` now triggers the same event
for native JavaScript code via `dispatchEvent()`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 57

  1. Andreas Kienast uploaded patch set 1 07/12/19, 11:12

  2. TYPO3com voted on patch set 1 V -1 07/12/19, 11:23 Completed build in 11m 21s on Fri, 12 Jul, 01:23 PM Test Summary: 3 of 47341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34956

  3. Andreas Kienast uploaded patch set 2 07/12/19, 12:44

  4. TYPO3com voted on patch set 2 V +1 07/12/19, 13:10 Completed build in 23m 28s on Fri, 12 Jul, 03:10 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34966

  5. Benni Mack voted on patch set 2 V +1 CR +1 07/13/19, 12:38

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 07/14/19, 10:57

  7. Andreas Kienast merged patch set 3 07/14/19, 10:57