Review main Merged

6128[BUGFIX] PageTS newRecord wizard options are unset by default

Chris topher CR +2 V +2 Easy +19 −11 updated 06/03/13, 20:49

Commit message

The following PageTS options are unset by default:
* mod.wizards.newRecord.pages.show.pageInside
* mod.wizards.newRecord.pages.show.pageAfter
* mod.wizards.newRecord.pages.show.pageSelectPosition

However, PHP codes treats these unset values (empty string) as being
enabled, which can lead to confusions.

Set the default value to 1.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Markus Klein +1
    • Francois Suter +1
    • Xavier Perseguers +1
  • Verified V +2
    • Steffen Gebert +2
    • Xavier Perseguers +1

Issues 2

Files 2

Review log 21

  1. Xavier Perseguers commented on patch set 1 10/21/11, 11:32

    Looks good to me, but someone else must approve
    Please add the release: Releases: 4.6
  2. Markus Klein commented on patch set 2 10/21/11, 11:32

    Looks good to me, but someone else must approve
  3. Oliver Klee commented on patch set 2 2 comments 10/21/11, 11:32

    I would prefer that you didn't submit this
  4. Xavier Perseguers commented on patch set 2 10/21/11, 11:32

    Looks good to me, but someone else must approve
  5. Steffen Gebert uploaded patch set 3 10/21/11, 11:32

    db_new.php:362 Reply

    That's the point of using empty() - it does not throw notices.
  6. Francois Suter commented on patch set 4 10/21/11, 11:32

    Looks good to me, but someone else must approve I'm fine with setting default values. It makes sense in this case. This has enough votes already, so go ahead!
  7. Markus Klein commented on patch set 4 10/21/11, 11:32

    (1 inline comment)
  8. Markus Klein commented on patch set 4 1 comment 10/21/11, 11:32

    Looks good to me, but someone else must approve
  9. Xavier Perseguers commented on patch set 4 10/21/11, 11:32

    Looks good to me, approved
  10. Xavier Perseguers commented on patch set 4 10/21/11, 11:32

    Verified; Looks good to me, but someone else must approve
  11. Steffen Gebert uploaded patch set 4 10/21/11, 11:32

  12. Steffen Gebert commented on patch set 4 10/21/11, 11:32

    (1 inline comment)
  13. Steffen Gebert commented on patch set 4 10/21/11, 11:32

    Verified; Looks good to me, but someone else must approve
  14. Chris topher uploaded patch set 2 10/21/11, 11:32

  15. Chris topher commented on patch set 2 10/21/11, 11:32

    Patch Set 2 takes your comment into account, Xavier and it sets the default value at the very _beginning_ of processing. That way we do not overwrite changes, which were done before, with the default value.
  16. Mr. Jenkins commented on patch set 1 10/21/11, 11:32

  17. Mr. Jenkins commented on patch set 2 10/21/11, 11:32

  18. Mr. Jenkins commented on patch set 3 10/21/11, 11:32

  19. Mr. Jenkins commented on patch set 4 10/21/11, 11:32

  20. Steffen Gebert commented on patch set 4 V 0 10/21/11, 11:32

    by team member; Looks good to me, approved
  21. Steffen Gebert merged patch set 4 10/21/11, 11:32