6128[BUGFIX] PageTS newRecord wizard options are unset by default
Commit message
Review
-
Code review CR +2
- Steffen Gebert +2
- Markus Klein +1
- Francois Suter +1
- Xavier Perseguers +1
-
Verified V +2
- Steffen Gebert +2
- Xavier Perseguers +1
Issues 2
Files 2
Review log 21
-
Xavier Perseguers commented on patch set 1 10/21/11, 11:32
Looks good to me, but someone else must approvePlease add the release: Releases: 4.6 -
Markus Klein commented on patch set 2 10/21/11, 11:32
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 2 2 comments 10/21/11, 11:32
I would prefer that you didn't submit this -
Xavier Perseguers commented on patch set 2 10/21/11, 11:32
Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 3 10/21/11, 11:32
db_new.php:362ReplyThat's the point of using empty() - it does not throw notices. -
Francois Suter commented on patch set 4 10/21/11, 11:32
Looks good to me, but someone else must approve I'm fine with setting default values. It makes sense in this case. This has enough votes already, so go ahead! -
Markus Klein commented on patch set 4 10/21/11, 11:32
(1 inline comment) -
Markus Klein commented on patch set 4 1 comment 10/21/11, 11:32
Looks good to me, but someone else must approve -
Xavier Perseguers commented on patch set 4 10/21/11, 11:32
Looks good to me, approved -
Xavier Perseguers commented on patch set 4 10/21/11, 11:32
Verified; Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 4 10/21/11, 11:32
-
Steffen Gebert commented on patch set 4 10/21/11, 11:32
(1 inline comment) -
Steffen Gebert commented on patch set 4 10/21/11, 11:32
Verified; Looks good to me, but someone else must approve -
Chris topher uploaded patch set 2 10/21/11, 11:32
-
Chris topher commented on patch set 2 10/21/11, 11:32
Patch Set 2 takes your comment into account, Xavier and it sets the default value at the very _beginning_ of processing. That way we do not overwrite changes, which were done before, with the default value. -
Mr. Jenkins commented on patch set 1 10/21/11, 11:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2210/ : SUCCESS -
Mr. Jenkins commented on patch set 2 10/21/11, 11:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2211/ : SUCCESS -
Mr. Jenkins commented on patch set 3 10/21/11, 11:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2214/ : SUCCESS -
Mr. Jenkins commented on patch set 4 10/21/11, 11:32
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2215/ : SUCCESS -
Steffen Gebert commented on patch set 4 V 0 10/21/11, 11:32
by team member; Looks good to me, approved -
Steffen Gebert merged patch set 4 10/21/11, 11:32