61281[!!!][TASK] Recordlist: Reduce inline js and remove global js vars
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/Recordlist.ts+61 −7
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88773-RecordlistReduceInlineJsAndRemoveGlobalJsVars.rst1new+22 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+1 −50
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php2+51 −99
- typo3/sysext/recordlist/Resources/Public/JavaScript/Recordlist.js+1 −1
Review log 1218
-
Daniel Windloff uploaded patch set 1 07/12/19, 13:54
-
TYPO3com voted on patch set 1 V -1 07/12/19, 13:58 Completed build in 01m 38s on Fri, 12 Jul, 03:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34973
-
Daniel Windloff uploaded patch set 2 07/15/19, 13:29
-
TYPO3com voted on patch set 2 V -1 07/15/19, 13:30 Completed build in 18s on Mon, 15 Jul, 03:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35042
-
Daniel Windloff uploaded patch set 3 07/15/19, 18:50
-
TYPO3com voted on patch set 3 V +1 07/15/19, 19:02 Completed build in 11m 20s on Mon, 15 Jul, 09:02 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35055
-
Daniel Windloff uploaded patch set 4 07/16/19, 08:30
-
TYPO3com voted on patch set 4 V +1 07/16/19, 08:46 Completed build in 12m 23s on Tue, 16 Jul, 10:46 AM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35075
-
Georg Ringer commented on patch set 4 CR -1 07/16/19, 13:51
attribute hasDatabaseRecordList.php:4181please add a scan for that method -
Daniel Windloff uploaded patch set 5 07/16/19, 14:32
-
Daniel Windloff commented on patch set 5 07/16/19, 14:38
Reply
DoneDatabaseRecordList.php:4181ReplyDone -
Oliver Klee updated the commit message in patch set 6 07/16/19, 14:42
-
TYPO3com voted on patch set 5 V +1 07/16/19, 14:43 Completed build in 10m 57s on Tue, 16 Jul, 04:43 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35100
-
TYPO3com voted on patch set 6 V +1 07/16/19, 14:53 Completed build in 10m 54s on Tue, 16 Jul, 04:53 PM Test Summary: 47117 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35101
-
Benni Mack commented on patch set 6 CR -1 07/17/19, 04:49
Breaking-88773-RecordlistReduceInlineJsAndRemoveGlobalJsVars.rst:12Unresolvedjust by reading the RST file, I don't get the change at all. Imagine you're writing a note to yourself in 18 months, or opening up this file for the first time. What would you expect to understand what happened? -
Andreas Kienast commented on patch set 6 CR -1 07/17/19, 06:36
I think the patch touches too many things at once that are barely related. - I'd suggest to start with BackendUtility::editOnClick() - replace every usage and add a proper deprecation - Clipboard is another big, cluttered topic (record list <> file list, for example) - I'm pretty sure there is potential to streamline the whole component -
Daniel Windloff commented on patch set 6 07/17/19, 07:12
> Patch Set 6: Code-Review-1 > > I think the patch touches too many things at once that are barely related. > - I'd suggest to start with BackendUtility::editOnClick() - replace every usage and add a proper deprecation > - Clipboard is another big, cluttered topic (record list <> file list, for example) - I'm pretty sure there is potential to streamline the whole component My starting point was the inline js code added in RecordListController, which is build there and in DatabaseRecordList and BackendUtility. I simply would remove these dependencies to get only one place where to find js. Touch the clipboard area was not the aim of this patch. IMHO the clipboad has conceptual problems (copy or move actions depending on the selected clipbord and not on the selected items; no separation between files and tca records even, ...). I'm fine starting with the replacement of BackendUtility::editOnClick, but I think it is also worth to move old js from inline js to one single place even if it could be also used in other parts of the core. I will abandon this patch and create others as replacement. -
Daniel Windloff abandoned the change 07/17/19, 07:15