Review main Merged

61283[TASK] Increase length of header_position field

Guido Schmechel CR +2 V +2 Easy +1 −1 updated 07/16/19, 20:04

Commit message

To prevent the truncation of new values via TCEForm,
the field length is increased to 255.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Daniel Goerz +1
    • Oliver Klee +1
    • Björn Jacob +1
    • Riccardo De Contardi +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Daniel Goerz +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Guido Schmechel uploaded patch set 1 07/12/19, 19:09

  2. TYPO3com voted on patch set 1 V +1 07/12/19, 19:20 Completed build in 10m 47s on Fri, 12 Jul, 09:20 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34981

  3. Oliver Klee commented on patch set 1 CR +1 07/13/19, 10:58

    Unresolved

    Is 8.7 affected as well?
  4. Björn Jacob voted on patch set 1 CR +1 07/13/19, 16:24

  5. Daniel Goerz voted on patch set 1 V +1 CR +1 07/13/19, 20:12

  6. Riccardo De Contardi commented on patch set 1 V +1 CR +1 07/14/19, 08:34

    verified on latest master with the code provided on the issue description.
  7. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 07/16/19, 20:04

  8. Tymoteusz Motylewski merged patch set 2 07/16/19, 20:04