Review main Merged

61285[BUGFIX] Remove native header() call in DocumentTemplate

Benni Mack CR +2 V +2 Easy +0 −1 updated 07/13/19, 20:14

Commit message

In DocumentTemplate there is always one header call
to define that everything is HTML and UTF-8.

Since we do PSR-7 in Backend Context, this should be handled
by the Response object, which we already do.

This should normally be a bugfix for existing stable versions,
although I'm very unsure on how this could affect any side-effects
where extensions rely on this behavior for years (!) already, so
this is master-only.

OTOH this change should not affect anything in regular BE
modules as they work with PSR-7 since TYPO3 v7 already.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 07/13/19, 14:40

  2. TYPO3com voted on patch set 1 V +1 07/13/19, 14:51 Completed build in 10m 30s on Sat, 13 Jul, 04:51 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35000

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 07/13/19, 14:59

  4. Oliver Klee voted on patch set 1 CR +1 07/13/19, 15:23

  5. Daniel Goerz voted on patch set 1 V +2 CR +2 07/13/19, 20:14

  6. Daniel Goerz merged patch set 2 07/13/19, 20:14