Review main Merged

61288[TASK] Deprecate internal public properties of TSFE

Benni Mack CR +2 V +2 Normal +165 −61 updated 08/26/19, 07:58

Commit message

Due to e50b1c1acdd5da514a35f837d9b853692bcfa16d
the TypoScriptFrontendController requires four objects
as constructor arguments while keeping maximum
compatibility by fetching fallback information from the
current PSR-7 object or setting data from the legacy arguments.

This allows for the following "internal" public properties
- TSFE->cHash
- TSFE->domainStartPage
- TSFE->cHash_array

to be deprecated.

The hashParameters for calculating the hashBase have been modified:

- "cHash" has been replaced by "dyamicArguments" but contains the same values
- "gr_list" is now called "groupIds"
- "domainStartPage" has been replaced by "site" (identifier of the site)

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1628

Show 23 earlier messages
  1. Benni Mack uploaded patch set 1 07/13/19, 16:25

  2. TYPO3com voted on patch set 1 V -1 07/13/19, 16:40 Completed build in 14m 09s on Sat, 13 Jul, 06:40 PM Test Summary: 2 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35004

  3. Benni Mack updated the commit message in patch set 2 07/13/19, 17:01

  1. TYPO3com voted on patch set 2 V +1 07/13/19, 17:16 Completed build in 14m 06s on Sat, 13 Jul, 07:16 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35008

  2. Benni Mack uploaded patch set 3 07/19/19, 12:08

  3. TYPO3com voted on patch set 3 V +1 07/19/19, 12:29 Completed build in 20m 08s on Fri, 19 Jul, 02:29 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35214

  4. Benni Mack uploaded patch set 4 07/24/19, 12:36

  5. TYPO3com voted on patch set 4 V +1 07/24/19, 12:49 Completed build in 12m 14s on Wed, 24 Jul, 02:49 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35307

  6. Benni Mack uploaded patch set 5 08/23/19, 05:57

  7. TYPO3com voted on patch set 5 V -1 08/23/19, 06:18 Completed build in 13m 21s on Fri, 23 Aug, 06:18 AM Test Summary: 1 of 47570 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35783

  8. Andreas Kienast uploaded patch set 6 08/23/19, 07:00

  9. TYPO3com voted on patch set 6 V -1 08/23/19, 07:10 Completed build in 09m 02s on Fri, 23 Aug, 07:10 AM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35784

  10. Andreas Kienast uploaded patch set 7 08/23/19, 07:11

  11. Andreas Kienast uploaded patch set 8 08/23/19, 07:15

  12. Andreas Kienast uploaded patch set 9 08/23/19, 07:21

  13. Andreas Kienast commented on patch set 9 08/23/19, 07:21

    Sorry for patch set spam, the rst validator is really picky about the _order_ of the tags...
  14. TYPO3com voted on patch set 7 V -1 08/23/19, 07:23 Completed build in 11m 52s on Fri, 23 Aug, 07:23 AM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35785

  15. TYPO3com voted on patch set 8 V -1 08/23/19, 07:27 Completed build in 11m 56s on Fri, 23 Aug, 07:27 AM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35786

  16. TYPO3com voted on patch set 9 V -1 08/23/19, 07:33 Completed build in 11m 53s on Fri, 23 Aug, 07:33 AM Test Summary: 1 of 47570 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35787

  17. TYPO3com voted on patch set 9 V +1 08/23/19, 07:35 Completed build in 26m 15s on Fri, 23 Aug, 07:35 AM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35787

  18. Anja Leichsenring commented on patch set 10 08/23/19, 10:22

    Published edit on patch set 9.
  19. Anja Leichsenring commented on patch set 10 CR -1 08/23/19, 10:27

    have you forgotten to push the changes to the matcher files, or is the FullyScanned tag in the rst an error?
  20. TYPO3com voted on patch set 10 V +1 08/23/19, 10:34 Completed build in 11m 34s on Fri, 23 Aug, 10:34 AM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35795

  21. Benni Mack uploaded patch set 11 08/26/19, 04:45

  22. TYPO3com voted on patch set 11 V +1 08/26/19, 05:08 Completed build in 11m 54s on Mon, 26 Aug, 05:08 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35835

  23. Georg Ringer voted on patch set 11 V +1 CR +1 08/26/19, 07:54

  24. Andreas Kienast voted on patch set 11 V +2 CR +2 08/26/19, 07:58

  25. Andreas Kienast merged patch set 12 08/26/19, 07:58