61289[TASK] Clean up TSFE constructor initialization
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 2
Files 2
Review log 1316
-
Benni Mack uploaded patch set 1 07/13/19, 17:03
-
TYPO3com voted on patch set 1 V +1 07/13/19, 17:18 Completed build in 14m 20s on Sat, 13 Jul, 07:18 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35009
-
Oliver Klee commented on patch set 1 07/13/19, 21:02
TypoScriptFrontendController.php:676UnresolvedSiteLanguage|int|string, I thinkTypoScriptFrontendController.php:688UnresolvedCan we have an @var annotation for this variable?TypoScriptFrontendController.php:775Unresolvedtype missingTypoScriptFrontendController.php:835Please let's name this differently than the parameter. -
Oliver Klee commented on patch set 1 07/16/19, 11:15
TypoScriptFrontendController.php:832UnresolvedI propose we convert this into a guard clause.TypoScriptFrontendController.php:834UnresolvedThis can be a guard clause, too.TypoScriptFrontendController.php:835Reply UnresolvedBackground: First, when I had a look at the method, I saw the declaration and the return value, and thought: "That's the same variable. We can drop the return statement as it's passed by reference." And then I read the method body and noticed that $pageArguments is first as the method argument, and after that for the return value (i.e., with a different meaning.) That's the kind of confusion we can avoid by not changing/overwriting parameters. -
Benni Mack uploaded patch set 2 07/18/19, 06:33
-
TYPO3com voted on patch set 2 V +1 07/18/19, 06:45 Completed build in 11m 07s on Thu, 18 Jul, 08:45 AM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35150
-
Georg Ringer voted on patch set 2 V +1 CR +1 07/18/19, 07:06
-
Susi Moog commented on patch set 2 07/18/19, 07:15
TypoScriptFrontendController.php:762Unresolvedshould this also trigger a deprecation log entry?TypoScriptFrontendController.php:791Unresolvedwhy not use `$this->type ?: ($queryParams['type'] ?? $request->getParsedBody()['type'] ?? 0);` -
Oliver Klee commented on patch set 2 07/18/19, 07:26
TypoScriptFrontendController.php:780UnresolvedHere, we can also have a type declaration for $pageArguments. -
Benni Mack uploaded patch set 3 07/18/19, 07:28
-
TYPO3com voted on patch set 3 V +1 07/18/19, 07:38 Completed build in 09m 52s on Thu, 18 Jul, 09:38 AM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35155
-
Susi Moog voted on patch set 3 CR +1 07/18/19, 07:59
-
Susi Moog voted on patch set 3 V +1 07/18/19, 08:09
-
Oliver Klee voted on patch set 3 CR +1 07/18/19, 10:18
-
Georg Ringer voted on patch set 3 V +2 CR +2 07/18/19, 10:59
-
Benni Mack merged patch set 4 07/18/19, 12:50
TypoScriptFrontendController.php:674Unresolved