Review main Merged

61291[TASK] Take care of rendering warnings in core Changelog rendering

Anja Leichsenring CR +2 V +2 Hard +185 −194 updated 07/17/19, 19:42

Commit message

Also, some improvements are made to sentence structure, tenses
and syntax highlightning.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Koen Wouters +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Koen Wouters +1
    • TYPO3com +1 CI

Issues 1

Files 32

Show 12 more files

Review log 1418

  1. Anja Leichsenring uploaded patch set 1 07/13/19, 20:28

  2. TYPO3com voted on patch set 1 V +1 07/13/19, 20:47 Completed build in 13m 40s on Sat, 13 Jul, 10:47 PM Test Summary: 47002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35016

  3. Anja Leichsenring uploaded patch set 2 07/14/19, 07:56

  4. TYPO3com voted on patch set 2 V +1 07/14/19, 08:08 Completed build in 12m 31s on Sun, 14 Jul, 10:08 AM Test Summary: 47002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35017

  5. Anja Leichsenring commented on patch set 2 CR -1 07/14/19, 09:46

    one more warning to tackle
  6. Anja Leichsenring uploaded patch set 3 07/14/19, 10:09

  7. TYPO3com voted on patch set 3 V +1 07/14/19, 10:19 Completed build in 09m 46s on Sun, 14 Jul, 12:19 PM Test Summary: 47002 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35020

  8. Andreas Kienast commented on patch set 3 CR -1 07/14/19, 10:44

    Feature-59396-TypolinkViewHelper.rst:23

    why php?

    Feature-82812-NewSyntaxForImportingTypoScriptFiles.rst:21

    IIRC Martin demanded three spaces on first level of indentation

    Deprecation-86907-DeprecateUsageOfDependencyInjectionWithNonPublicProperties.rst:12 Unresolved

    as deprecated

    Feature-86973-TypoScriptGetTextPropertySiteLanguage.rst:19 Unresolved

    Also the indentation thing

    Important-87028-AccessObjectsFromObjectStorageUsingNumericValue.rst:19 Unresolved

    And here
  9. Anja Leichsenring commented on patch set 3 07/14/19, 10:55

    Feature-59396-TypolinkViewHelper.rst:23 Reply

    because html is not supported and throws a warning.

    Feature-82812-NewSyntaxForImportingTypoScriptFiles.rst:21 Reply Unresolved

    then I have to adjust each and every code example there is. All intended by 4.
  10. Anja Leichsenring commented on patch set 4 07/14/19, 10:55

    Published edit on patch set 3.
  11. TYPO3com voted on patch set 4 V +1 07/14/19, 11:10 Completed build in 15m 29s on Sun, 14 Jul, 01:10 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35022

  12. Andreas Kienast commented on patch set 4 07/15/19, 06:30

    Feature-59396-TypolinkViewHelper.rst:23 Reply

    Is it only unsupported for code blocks?
  13. Anja Leichsenring commented on patch set 4 07/15/19, 07:42

    Feature-59396-TypolinkViewHelper.rst:23 Reply

    I guess so, asked in docu team if so and how to overcome.
  14. Anja Leichsenring commented on patch set 4 07/15/19, 20:01

    Feature-59396-TypolinkViewHelper.rst:23 Reply Unresolved

    should work, but doesn't. After this is a v7.0 file, can we just let it go? The example is properly rendered, the impact should be minimal.
  15. Georg Ringer voted on patch set 4 V +1 CR +1 07/16/19, 13:48

  16. Koen Wouters voted on patch set 4 V +1 CR +1 07/17/19, 17:34

  17. Anja Leichsenring voted on patch set 4 V +2 CR +2 07/17/19, 19:42

  18. Anja Leichsenring merged patch set 5 07/17/19, 19:42