61293[!!!][TASK] RecordList: Streamline page edit, view and localization handling
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/backend/Classes/Template/Components/Buttons/SplitButton.php5+36 −13
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88752-RecordListStreamlinePageEditAndLocaliziationHandling.rstnew+26 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+9 −0
- typo3/sysext/recordlist/Classes/Controller/RecordListController.php+0 −99
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+136 −59
Review log 1522
-
Daniel Windloff uploaded patch set 1 07/15/19, 07:14
-
Daniel Windloff uploaded patch set 2 07/15/19, 07:24
-
TYPO3com voted on patch set 1 V -1 07/15/19, 07:26 Completed build in 11m 26s on Mon, 15 Jul, 09:26 AM Test Summary: 17 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35025
-
TYPO3com voted on patch set 2 V +1 07/15/19, 07:38 Completed build in 13m 42s on Mon, 15 Jul, 09:38 AM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35026
-
Daniel Windloff uploaded patch set 3 07/15/19, 07:41
-
TYPO3com voted on patch set 3 V +1 07/15/19, 08:09 Completed build in 24m 55s on Mon, 15 Jul, 10:09 AM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35030
-
Daniel Windloff uploaded patch set 4 07/15/19, 11:57
-
TYPO3com voted on patch set 4 V +1 07/15/19, 12:10 Completed build in 12m 03s on Mon, 15 Jul, 02:10 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35040
-
Markus Klein commented on patch set 4 07/19/19, 09:33
SplitButton.php:159value of 0 wouldn't be allowed here -
Daniel Windloff commented on patch set 4 07/19/19, 09:46
SplitButton.php:150ReplyThe main problem was that the split button would like to have AbstractButton in addItem, but doesn't work for link buttons, which is also an AbstactButton. I see two other options: - Replace method_exists with instanceof against InputButton and Linkbutton (which is more or less the same solution) - Implement two split button and add as Typehint InputButton or LinkButton for addItem -
Markus Klein commented on patch set 4 07/19/19, 09:50
SplitButton.php:150Reply Unresolvedokay, I have no opinion anymore. ;-) -
Daniel Windloff uploaded patch set 5 07/19/19, 10:12
-
Daniel Windloff commented on patch set 5 07/19/19, 10:13
SplitButton.php:159ReplyDone -
TYPO3com voted on patch set 5 V +1 07/19/19, 10:25 Completed build in 12m 45s on Fri, 19 Jul, 12:25 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35199
-
Daniel Windloff commented on patch set 5 CR -1 07/23/19, 10:56
On it -
Oliver Klee updated the commit message in patch set 6 07/23/19, 12:18
-
TYPO3com voted on patch set 6 V +1 07/23/19, 12:29 Completed build in 10m 22s on Tue, 23 Jul, 02:29 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35290
-
Daniel Windloff uploaded patch set 7 07/23/19, 12:39
-
TYPO3com voted on patch set 7 V -1 07/23/19, 12:40 Completed build in 13s on Tue, 23 Jul, 02:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35291
-
Daniel Windloff commented on patch set 7 07/23/19, 12:40
-1 Still on it -
Daniel Windloff marked it work in progress 07/29/19, 09:25
-
Daniel Windloff abandoned the change 01/29/20, 21:37
Changes are abendoned, that where reqired to continue here
SplitButton.php:150