Review main Abandoned Breaking

61293[!!!][TASK] RecordList: Streamline page edit, view and localization handling

Daniel Windloff CR 0 V 0 Hard +207 −171 updated 01/29/20, 21:37

Commit message

Move actions, that are related to page edit and page localization to the
button bar.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 1522

  1. Daniel Windloff uploaded patch set 1 07/15/19, 07:14

  2. Daniel Windloff uploaded patch set 2 07/15/19, 07:24

  3. TYPO3com voted on patch set 1 V -1 07/15/19, 07:26 Completed build in 11m 26s on Mon, 15 Jul, 09:26 AM Test Summary: 17 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35025

  4. TYPO3com voted on patch set 2 V +1 07/15/19, 07:38 Completed build in 13m 42s on Mon, 15 Jul, 09:38 AM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35026

  5. Daniel Windloff uploaded patch set 3 07/15/19, 07:41

  6. TYPO3com voted on patch set 3 V +1 07/15/19, 08:09 Completed build in 24m 55s on Mon, 15 Jul, 10:09 AM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35030

  7. Daniel Windloff uploaded patch set 4 07/15/19, 11:57

  8. TYPO3com voted on patch set 4 V +1 07/15/19, 12:10 Completed build in 12m 03s on Mon, 15 Jul, 02:10 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35040

  9. Markus Klein commented on patch set 4 07/19/19, 09:33

    SplitButton.php:150

    is there any way to make this nicer than having this duck-typing style of programming?

    SplitButton.php:159

    value of 0 wouldn't be allowed here
  10. Daniel Windloff commented on patch set 4 07/19/19, 09:46

    SplitButton.php:150 Reply

    The main problem was that the split button would like to have AbstractButton in addItem, but doesn't work for link buttons, which is also an AbstactButton. I see two other options: - Replace method_exists with instanceof against InputButton and Linkbutton (which is more or less the same solution) - Implement two split button and add as Typehint InputButton or LinkButton for addItem
  11. Markus Klein commented on patch set 4 07/19/19, 09:50

    SplitButton.php:150 Reply Unresolved

    okay, I have no opinion anymore. ;-)
  12. Daniel Windloff uploaded patch set 5 07/19/19, 10:12

  13. Daniel Windloff commented on patch set 5 07/19/19, 10:13

    SplitButton.php:159 Reply

    Done
  14. TYPO3com voted on patch set 5 V +1 07/19/19, 10:25 Completed build in 12m 45s on Fri, 19 Jul, 12:25 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35199

  15. Daniel Windloff commented on patch set 5 CR -1 07/23/19, 10:56

    On it
  16. Oliver Klee updated the commit message in patch set 6 07/23/19, 12:18

  17. TYPO3com voted on patch set 6 V +1 07/23/19, 12:29 Completed build in 10m 22s on Tue, 23 Jul, 02:29 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35290

  18. Daniel Windloff uploaded patch set 7 07/23/19, 12:39

  19. TYPO3com voted on patch set 7 V -1 07/23/19, 12:40 Completed build in 13s on Tue, 23 Jul, 02:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35291

  20. Daniel Windloff commented on patch set 7 07/23/19, 12:40

    -1 Still on it
  21. Daniel Windloff marked it work in progress 07/29/19, 09:25

  22. Daniel Windloff abandoned the change 01/29/20, 21:37

    Changes are abendoned, that where reqired to continue here