Review main Merged Breaking

61296[!!!][TASK] Always concatenate all given files in ResourceCompressor

Benni Mack CR +2 V +2 Normal +87 −53 updated 07/16/19, 13:00

Commit message

ResourceCompressor allows to only concatenate files
given in a given "baseDirectory" as separate option, which
was used to only include files that are registered via TBE_STYLES
for backend purposes.

The functionality is removed to always concatenate all CSS files
in TYPO3 Backend.

A heavy dependency to DocumentTemplate of ALL backend
functionality using PageRenderer is therefore removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2029

Show 34 earlier messages
  1. Benni Mack uploaded patch set 1 07/15/19, 09:46

  2. TYPO3com voted on patch set 1 V -1 07/15/19, 10:02 Completed build in 14m 58s on Mon, 15 Jul, 12:02 PM Test Summary: 64 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35035

  3. Benni Mack uploaded patch set 2 07/15/19, 15:05

  4. Benni Mack updated the commit message in patch set 3 07/15/19, 15:06

  1. TYPO3com voted on patch set 3 V +1 07/15/19, 15:18 Completed build in 12m 16s on Mon, 15 Jul, 05:18 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35048

  2. TYPO3com voted on patch set 2 V +1 07/15/19, 15:19 Completed build in 13m 16s on Mon, 15 Jul, 05:18 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35047

  3. Susi Moog commented on patch set 3 07/15/19, 15:25

    Scenario: in an extension in typo3conf: $GLOBALS['TBE_STYLES']['skins']['introduction'] = [ 'stylesheetDirectories' => [ 'css' => 'EXT:introduction/Resources' ] ]; Result: the main backend.css file (main module/page tree styling) works fine, however the CSS file for the page module (or content frame in general) does not work at all because of PHP Warning Core: Error handler (BE): PHP Warning: file_get_contents(/var/www/html/public/typo3//var/www/html/public/typo3conf/ext/introduction/Resources/be_styles.css): failed to open stream: No such file or directory in /var/www/html/Packages/TYPO3.CMS/typo3/sysext/core/Classes/Resource/ResourceCompressor.php line 281 (note the applied prefix path)
  4. Susi Moog voted on patch set 3 V -1 07/15/19, 15:25

  5. Susi Moog uploaded patch set 4 07/15/19, 15:37

  6. Susi Moog commented on patch set 4 07/15/19, 15:39

    @Benni: not sure if you are fine with this solution, I basically just adjusted ModuleTemplate to use the same logic to load custom styles as DocumentTemplate - the underlying error however seems to be that the ResourceCompressor is unable to handle an array of absolute files if they are in typo3conf/ext in backend context. DocumentTemplate (and now ModuleTemplate) now use relative paths.
  7. TYPO3com voted on patch set 4 V +1 07/15/19, 15:53 Completed build in 13m 50s on Mon, 15 Jul, 05:53 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35051

  8. Benni Mack uploaded patch set 5 07/15/19, 19:49

  9. Benni Mack commented on patch set 5 07/15/19, 19:50

    Hey Susi, nope, actually the other way around: avoid getRelativePathTo() as it relies on the "currentScript" call.
  10. TYPO3com voted on patch set 5 V -1 07/15/19, 20:06 Completed build in 11m 12s on Mon, 15 Jul, 10:06 PM Test Summary: 64 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35060

  11. Susi Moog commented on patch set 5 V -1 07/15/19, 20:08

    now neither DocumentTemplate nor ModuleTemplate work...
  12. Susi Moog uploaded patch set 6 07/16/19, 08:29

  13. TYPO3com voted on patch set 6 V -1 07/16/19, 08:43 Completed build in 13m 22s on Tue, 16 Jul, 10:43 AM Test Summary: 64 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35074

  14. Susi Moog commented on patch set 6 07/16/19, 08:48

    [now it just doesn't work in subdirectories. I hate path handling.]
  15. Susi Moog commented on patch set 6 07/16/19, 09:22

    > Patch Set 6: > > [now it just doesn't work in subdirectories. I hate path handling.] correction: with be debug = 1
  16. Susi Moog uploaded patch set 7 07/16/19, 09:40

  17. TYPO3com voted on patch set 7 V -1 07/16/19, 09:41 Completed build in 16s on Tue, 16 Jul, 11:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35078

  18. Susi Moog uploaded patch set 8 07/16/19, 09:42

  19. TYPO3com voted on patch set 8 V -1 07/16/19, 09:42 Completed build in 33s on Tue, 16 Jul, 11:42 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35080

  20. Susi Moog uploaded patch set 9 07/16/19, 09:43

  21. TYPO3com voted on patch set 9 V +1 07/16/19, 09:57 Completed build in 14m 00s on Tue, 16 Jul, 11:57 AM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35081

  22. Susi Moog commented on patch set 9 07/16/19, 10:25

    now allowing absolute paths to files to be handled in compressor logic - file path logic takes care of adjusting the path afterwards anyway.
  23. Benni Mack voted on patch set 9 V +1 CR +1 07/16/19, 12:52

  24. Andreas Kienast voted on patch set 9 V +2 CR +2 07/16/19, 13:00

  25. Andreas Kienast merged patch set 10 07/16/19, 13:00