61297[TASK] RecordListController: psr-7, Code Cleanup
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Felix P. +1
- Steffen Frese +1
-
Verified V +2 Done
- Benni Mack +2
- Felix P. +1
- Steffen Frese +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 810
-
Daniel Windloff uploaded patch set 1 07/15/19, 09:47
-
Daniel Windloff uploaded patch set 2 07/15/19, 09:48
-
TYPO3com voted on patch set 1 V +1 07/15/19, 10:06 Completed build in 19m 04s on Mon, 15 Jul, 12:06 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35036
-
TYPO3com voted on patch set 2 V +1 07/15/19, 10:14 Completed build in 20m 16s on Mon, 15 Jul, 12:14 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35038
-
Oliver Klee commented on patch set 2 07/15/19, 10:32
I really like these cleanups, and I propose splitting this change up into 2 or 3 separate, focused ones so we have "one kind of change per commit" (and the changesets also are easier to review). -
Steffen Frese voted on patch set 2 V +1 CR +1 01/16/20, 14:36
-
Felix P. voted on patch set 2 V +1 CR +1 01/17/20, 11:23
-
Benni Mack voted on patch set 2 V +2 CR +2 01/18/20, 15:40
-
Benni Mack merged patch set 3 01/18/20, 15:40
-
Benni Mack commented on patch set 3 01/18/20, 15:51
> Patch Set 2: > > I really like these cleanups, and I propose splitting this change up into 2 or 3 separate, focused ones so we have "one kind of change per commit" (and the changesets also are easier to review). aah, VERY much sorry Oli! Did not see your feedback here. Will consider your feedback for other changes like this though.