61298[BUGFIX] Adjust middleware processing order for Admin Panel
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 45
-
Oliver Hader uploaded patch set 1 07/15/19, 13:43
-
TYPO3com voted on patch set 1 V +1 07/15/19, 13:55 Completed build in 11m 34s on Mon, 15 Jul, 03:55 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35044
-
Susi Moog commented on patch set 1 CR -1 07/15/19, 14:29
from a quick look at it: shouldn't the same error happen for workspace-preview which is now also called before the tsfe middleware and accesses $GLOBALS['TSFE']?RequestMiddlewares.php:20Unresolvedpage resolver can probably be removed, the main dependency here is tsfe (before Bennis tsfe change the initializor had a "before: page-resolver" so init should not depend on a resolved page) -
Susi Moog commented on patch set 1 07/15/19, 14:31
[and workspace preview seems to be calling set_no_cache after the response was already generated, something looks fishy.] -
Susi Moog abandoned the change 08/29/19, 18:11
Fixed differently in https://review.typo3.org/c/Packages/TYPO3.CMS/+/61323