Review main Abandoned

61298[BUGFIX] Adjust middleware processing order for Admin Panel

Oliver Hader CR 0 V 0 Easy +2 −2 updated 08/29/19, 18:11

Commit message

`typo3/cms-adminpanel/initiator` has been processed before
`typo3/cms-frontend/tsfe` which was too early. As a result
curent requested frontend page id could not be assigned.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 07/15/19, 13:43

  2. TYPO3com voted on patch set 1 V +1 07/15/19, 13:55 Completed build in 11m 34s on Mon, 15 Jul, 03:55 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35044

  3. Susi Moog commented on patch set 1 CR -1 07/15/19, 14:29

    from a quick look at it: shouldn't the same error happen for workspace-preview which is now also called before the tsfe middleware and accesses $GLOBALS['TSFE']?

    RequestMiddlewares.php:20 Unresolved

    page resolver can probably be removed, the main dependency here is tsfe (before Bennis tsfe change the initializor had a "before: page-resolver" so init should not depend on a resolved page)
  4. Susi Moog commented on patch set 1 07/15/19, 14:31

    [and workspace preview seems to be calling set_no_cache after the response was already generated, something looks fishy.]
  5. Susi Moog abandoned the change 08/29/19, 18:11