Review main Merged Breaking

61300[!!!][FEATURE] Omit type=text/javascript in HTML5 script tags

Benni Mack CR +2 V +2 Normal +104 −63 updated 07/16/19, 16:13

Commit message

HTML5 defines that <script tags do not need "type=text/javascript"
as additional attribute.

TYPO3 Backend is fully HTML5, so all parts can be removed there.

For Frontend, when having config.doctype = html5 (or empty),
then the attributes do not get added anymore as well.

If necessary, for Frontend rendering the attribute can be
added in HTML5 by specifying
includeJS.myfile.type = text/javascript
in TypoScript.

As this modifies Frontend output, it is considered breaking.

Also see W3C specification:
https://www.w3.org/TR/html52/semantics-scripting.html#element-attrdef-script-type

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1620

  1. Benni Mack uploaded patch set 1 07/15/19, 14:57

  2. TYPO3com voted on patch set 1 V -1 07/15/19, 15:07 Completed build in 09m 59s on Mon, 15 Jul, 05:07 PM Test Summary: 113 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35046

  3. Oliver Hader commented on patch set 1 CR +1 07/15/19, 15:10

    Please add reference to https://www.w3.org/TR/html52/semantics-scripting.html#element-attrdef-script-type Specification suggests to omit superfluous text/javascript "type". Attribute "language" has become obsolete - "type" has taken precedence over "language" already in the past
  4. Benni Mack uploaded patch set 2 07/15/19, 20:21

  5. TYPO3com voted on patch set 2 V +1 07/15/19, 20:38 Completed build in 16m 54s on Mon, 15 Jul, 10:38 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35064

  6. Oliver Klee voted on patch set 2 CR +1 07/15/19, 21:41

  7. Markus Klein commented on patch set 2 07/15/19, 21:53

    Can be removed from typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html:99 typo3/sysext/core/Classes/Page/PageRenderer.php:343 typo3/sysext/core/Classes/Resource/ResourceCompressor.php:203 typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Widget/Autocomplete/Index.html:1 typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php:2910 too?
  8. Chris Müller commented on patch set 2 CR -1 07/16/19, 04:21

    In PageRenderer the wrong property is used.

    PageRenderer.php:2157 Unresolved

    This has to be $properties['type'], not $properties['integrity']
  9. Andreas Kienast uploaded patch set 3 07/16/19, 07:06

  10. TYPO3com voted on patch set 3 V -1 07/16/19, 07:17 Completed build in 10m 17s on Tue, 16 Jul, 09:17 AM Test Summary: 3 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35072

  11. Markus Klein commented on patch set 3 CR -1 07/16/19, 07:26

    Repeating my question: Can be removed from typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html:99 typo3/sysext/core/Classes/Page/PageRenderer.php:343 typo3/sysext/core/Classes/Resource/ResourceCompressor.php:203 typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Widget/Autocomplete/Index.html:1 typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php:2910 too?
  12. Benni Mack commented on patch set 3 07/16/19, 11:15

    > Patch Set 3: Code-Review-1 > > Repeating my question: > > Can be removed from > > typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html:99 > typo3/sysext/core/Classes/Page/PageRenderer.php:343 > typo3/sysext/core/Classes/Resource/ResourceCompressor.php:203 > typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Widget/Autocomplete/Index.html:1 > > too? Only > typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html:99 > typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php:2910 can be changed safely, all others do not have the information about HTML5 at that point.
  13. Benni Mack uploaded patch set 4 07/16/19, 11:16

  14. Markus Klein voted on patch set 4 CR +1 07/16/19, 11:20

  15. TYPO3com voted on patch set 4 V +1 07/16/19, 11:32 Completed build in 16m 23s on Tue, 16 Jul, 01:32 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35087

  16. Georg Ringer voted on patch set 4 V +1 CR +1 07/16/19, 13:45

  17. Oliver Klee voted on patch set 4 CR +1 07/16/19, 13:49

  18. Andreas Kienast voted on patch set 4 CR +1 07/16/19, 13:54

  19. Oliver Hader voted on patch set 4 V +2 CR +2 07/16/19, 16:12

  20. Oliver Hader merged patch set 5 07/16/19, 16:13