61300[!!!][FEATURE] Omit type=text/javascript in HTML5 script tags
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Oliver Klee +1
- Markus Klein +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oliver Hader +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 25
- typo3/sysext/adminpanel/Classes/Utility/ResourceUtility.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/EditController.php+1 −1
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/Main.html+1 −1
- typo3/sysext/backend/Resources/Public/Html/Close.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php1+8 −19
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Breaking-88772-JavaScriptScriptTagsOmitTypetextjavascriptInHTML5.rstnew+54 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+4 −0
- typo3/sysext/extbase/Classes/Mvc/Web/Response.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Widget/AutocompleteViewHelper.php+2 −2
- typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Be/Widget/Paginate/Index.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Layouts/FormEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Templates/FormManager/Index.html+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+4 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+9 −18
- typo3/sysext/frontend/Tests/Unit/Controller/Fixtures/renderedPage.html+1 −1
- typo3/sysext/install/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/Init.html+3 −3
- typo3/sysext/install/Resources/Private/Templates/Layout/Init.html+3 −3
Show 5 more files
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/redirects/Resources/Private/Partials/Pagination.html+1 −1
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php+1 −1
- typo3/sysext/t3editor/Resources/Private/tsref.xml+1 −1
- typo3/sysext/workspaces/Resources/Private/Templates/Review/Index.html+1 −1
Review log 1620
-
Benni Mack uploaded patch set 1 07/15/19, 14:57
-
TYPO3com voted on patch set 1 V -1 07/15/19, 15:07 Completed build in 09m 59s on Mon, 15 Jul, 05:07 PM Test Summary: 113 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35046
-
Oliver Hader commented on patch set 1 CR +1 07/15/19, 15:10
Please add reference to https://www.w3.org/TR/html52/semantics-scripting.html#element-attrdef-script-type Specification suggests to omit superfluous text/javascript "type". Attribute "language" has become obsolete - "type" has taken precedence over "language" already in the past -
Benni Mack uploaded patch set 2 07/15/19, 20:21
-
TYPO3com voted on patch set 2 V +1 07/15/19, 20:38 Completed build in 16m 54s on Mon, 15 Jul, 10:38 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35064
-
Oliver Klee voted on patch set 2 CR +1 07/15/19, 21:41
-
Markus Klein commented on patch set 2 07/15/19, 21:53
Can be removed from typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html:99 typo3/sysext/core/Classes/Page/PageRenderer.php:343 typo3/sysext/core/Classes/Resource/ResourceCompressor.php:203 typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Widget/Autocomplete/Index.html:1 typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php:2910 too? -
Chris Müller commented on patch set 2 CR -1 07/16/19, 04:21
In PageRenderer the wrong property is used.PageRenderer.php:2157UnresolvedThis has to be $properties['type'], not $properties['integrity'] -
Andreas Kienast uploaded patch set 3 07/16/19, 07:06
-
TYPO3com voted on patch set 3 V -1 07/16/19, 07:17 Completed build in 10m 17s on Tue, 16 Jul, 09:17 AM Test Summary: 3 of 47361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35072
-
Markus Klein commented on patch set 3 CR -1 07/16/19, 07:26
Repeating my question: Can be removed from typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html:99 typo3/sysext/core/Classes/Page/PageRenderer.php:343 typo3/sysext/core/Classes/Resource/ResourceCompressor.php:203 typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Widget/Autocomplete/Index.html:1 typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php:2910 too? -
Benni Mack commented on patch set 3 07/16/19, 11:15
> Patch Set 3: Code-Review-1 > > Repeating my question: > > Can be removed from > > typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html:99 > typo3/sysext/core/Classes/Page/PageRenderer.php:343 > typo3/sysext/core/Classes/Resource/ResourceCompressor.php:203 > typo3/sysext/fluid/Resources/Private/Templates/ViewHelpers/Widget/Autocomplete/Index.html:1 > > too? Only > typo3/sysext/beuser/Resources/Private/Templates/Permission/Edit.html:99 > typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php:2910 can be changed safely, all others do not have the information about HTML5 at that point. -
Benni Mack uploaded patch set 4 07/16/19, 11:16
-
Markus Klein voted on patch set 4 CR +1 07/16/19, 11:20
-
TYPO3com voted on patch set 4 V +1 07/16/19, 11:32 Completed build in 16m 23s on Tue, 16 Jul, 01:32 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35087
-
Georg Ringer voted on patch set 4 V +1 CR +1 07/16/19, 13:45
-
Oliver Klee voted on patch set 4 CR +1 07/16/19, 13:49
-
Andreas Kienast voted on patch set 4 CR +1 07/16/19, 13:54
-
Oliver Hader voted on patch set 4 V +2 CR +2 07/16/19, 16:12
-
Oliver Hader merged patch set 5 07/16/19, 16:13