Review TYPO3_8-7 Merged

61302[BUGFIX] Handle l10n_parent with TCA type group correctly

Markus Klein CR +2 V +2 Easy +6 −5 updated 10/29/19, 10:20

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Markus Klein uploaded patch set 1 07/15/19, 15:30

  2. TYPO3com voted on patch set 1 V +1 07/15/19, 15:51 Completed build in 21m 39s on Mon, 15 Jul, 05:51 PM Test Summary: 80366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3574

  3. Markus Klein updated the commit message in patch set 2 07/15/19, 21:12

  4. Anja Leichsenring commented on patch set 2 V +1 CR -1 07/15/19, 21:15

    the patch works as advertised, but I'd like to add a test with a styleguide example to prevent future breakage again.
  5. TYPO3com voted on patch set 2 V +1 07/15/19, 21:33 Completed build in 21m 16s on Mon, 15 Jul, 11:33 PM Test Summary: 80366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3575

  6. Mathias Brodala commented on patch set 2 07/16/19, 06:42

    DatabaseLanguageRows.php:55

    This could be shortened: $parentUid = (int)($result['databaseRow'][$fieldWithUidOfDefaultRecord][0]['uid'] ?? $result['databaseRow'][$fieldWithUidOfDefaultRecord])
  7. Markus Klein commented on patch set 2 07/16/19, 07:06

    DatabaseLanguageRows.php:55 Reply Unresolved

    Yes that's true, but I would keep the long form here to "document" this array special case. Maybe better lets add a comment that tells the story about group fields here.
  8. Anja Leichsenring commented on patch set 2 CR 0 08/01/19, 12:02

    seems I find no time to make true on my promise.
  9. Benni Mack voted on patch set 2 CR +1 09/26/19, 11:56

  10. Susi Moog voted on patch set 2 CR +1 10/22/19, 10:40

  11. Benni Mack voted on patch set 2 V +2 CR +2 10/29/19, 10:20

  12. Benni Mack merged patch set 3 10/29/19, 10:20