Review main Merged

61307[BUGFIX] Clear page cache: show status, prevent multiple clicks

Daniel Windloff CR +2 V +2 Normal +56 −24 updated 07/30/19, 13:38

Commit message

Replace the clear cache button with a spinner during the AJAX request.
While the request is executed, the button is no clickable due to
addiional properties and classes being set.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Daniel Windloff uploaded patch set 1 07/16/19, 14:24

  2. TYPO3com voted on patch set 1 V +1 07/16/19, 14:37 Completed build in 13m 10s on Tue, 16 Jul, 04:37 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35099

  3. Guido Schmechel commented on patch set 1 V +1 07/23/19, 19:21

    Verified on current master
  4. Jonas Eberle voted on patch set 1 V +1 07/29/19, 19:38

  5. Andreas Kienast commented on patch set 1 CR -1 07/29/19, 19:42

    ClearCache.ts:35

    Please set a proper "disabled" class and attribute to the button instead.
  6. Daniel Windloff uploaded patch set 2 07/30/19, 07:19

  7. Daniel Windloff commented on patch set 2 07/30/19, 07:21

    > Patch Set 1: Code-Review-1 > > (1 comment)

    ClearCache.ts:35 Reply

    Replaced clicket attr with class "disabled"
  8. TYPO3com voted on patch set 2 V +1 07/30/19, 07:30 Completed build in 10m 11s on Tue, 30 Jul, 09:29 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35378

  9. Andreas Kienast uploaded patch set 3 07/30/19, 13:08

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 07/30/19, 13:08

  11. Andreas Kienast uploaded patch set 4 07/30/19, 13:16

  12. TYPO3com voted on patch set 3 V -1 07/30/19, 13:20 Completed build in 11m 23s on Tue, 30 Jul, 01:20 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35385

  13. Andreas Kienast voted on patch set 4 V +1 CR +1 07/30/19, 13:25

  14. TYPO3com voted on patch set 4 V +1 07/30/19, 13:27 Completed build in 10m 09s on Tue, 30 Jul, 01:27 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35386

  15. Frank Nägler voted on patch set 4 V +2 CR +2 07/30/19, 13:38

  16. Frank Nägler merged patch set 5 07/30/19, 13:38