61311[FEATURE] Introduce PreviewAspect for handling the preview flag
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php2+14 −3
- typo3/sysext/core/Classes/Context/Context.php+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-88791-IntroducePreviewAspectInContext.rstnew+27 −0
- typo3/sysext/frontend/Classes/Aspect/PreviewAspect.phpnew+60 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php5+113 −18
- typo3/sysext/frontend/Classes/Hooks/FrontendHooks.php+3 −1
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+2 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+5 −0
Review log 1419
-
Susi Moog uploaded patch set 1 07/17/19, 15:50
-
TYPO3com voted on patch set 1 V +1 07/17/19, 16:01 Completed build in 10m 51s on Wed, 17 Jul, 06:01 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35135
-
Oliver Klee commented on patch set 1 07/17/19, 16:16
TypoScriptFrontendController.php:879Can we merge/nest these two ifs? -
Susi Moog uploaded patch set 2 07/17/19, 16:23
-
Susi Moog commented on patch set 2 07/17/19, 16:23
Moved to EXT:frontend and added convenience method at Bennis request.PreviewModule.php:252ReplyDoneTypoScriptFrontendController.php:879Replynot in this patch, please. I'm trying to be as unobstrusive as possible here ;) -
Oliver Klee commented on patch set 2 07/17/19, 16:26
TypoScriptFrontendController.php:879ReplyAck -
TYPO3com voted on patch set 2 V +1 07/17/19, 16:34 Completed build in 10m 40s on Wed, 17 Jul, 06:34 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35136
-
Benni Mack uploaded patch set 3 07/18/19, 14:33
-
TYPO3com voted on patch set 3 V +1 07/18/19, 14:43 Completed build in 10m 02s on Thu, 18 Jul, 04:43 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35173
-
Andreas Kienast commented on patch set 3 07/18/19, 15:03
TypoScriptFrontendController.php:482Unresolvedv11.0TypoScriptFrontendController.php:4014UnresolvedThe patch is not breaking anymore with this fallback in place, is it? -
Benni Mack uploaded patch set 4 07/19/19, 06:12
-
TYPO3com voted on patch set 4 V +1 07/19/19, 06:23 Completed build in 10m 15s on Fri, 19 Jul, 08:23 AM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35179
-
Benni Mack voted on patch set 4 V +1 CR +1 07/19/19, 06:34
-
Susi Moog uploaded patch set 5 07/19/19, 07:28
-
TYPO3com voted on patch set 5 V +1 07/19/19, 07:38 Completed build in 10m 22s on Fri, 19 Jul, 09:38 AM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35186
-
Benni Mack voted on patch set 5 V +1 CR +1 07/19/19, 07:59
-
Frank Nägler voted on patch set 5 CR +1 07/19/19, 08:31
-
Andreas Kienast voted on patch set 5 V +2 CR +2 07/19/19, 08:39
-
Andreas Kienast merged patch set 6 07/19/19, 08:39
PreviewModule.php:252