Review main Merged

61311[FEATURE] Introduce PreviewAspect for handling the preview flag

Susi Moog CR +2 V +2 Normal +225 −22 updated 07/19/19, 08:39

Commit message

The public internal property of TSFE "fePreview" has been deprecated
in favor of a dedicated aspect handling the frontend preview flag.

As a first step, the frontend preview aspect only contains a boolean
flag holding the current preview state - but it might be extended with
additional information on the preview mode at a later point.

This is also a first step to remove the TSFE dependencies from the
AdminPanel initialisation process.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1419

  1. Susi Moog uploaded patch set 1 07/17/19, 15:50

  2. TYPO3com voted on patch set 1 V +1 07/17/19, 16:01 Completed build in 10m 51s on Wed, 17 Jul, 06:01 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35135

  3. Oliver Klee commented on patch set 1 07/17/19, 16:16

    PreviewModule.php:252

    type?

    TypoScriptFrontendController.php:879

    Can we merge/nest these two ifs?
  4. Susi Moog uploaded patch set 2 07/17/19, 16:23

  5. Susi Moog commented on patch set 2 07/17/19, 16:23

    Moved to EXT:frontend and added convenience method at Bennis request.

    PreviewModule.php:252 Reply

    Done

    TypoScriptFrontendController.php:879 Reply

    not in this patch, please. I'm trying to be as unobstrusive as possible here ;)
  6. Oliver Klee commented on patch set 2 07/17/19, 16:26

    TypoScriptFrontendController.php:879 Reply

    Ack
  7. TYPO3com voted on patch set 2 V +1 07/17/19, 16:34 Completed build in 10m 40s on Wed, 17 Jul, 06:34 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35136

  8. Benni Mack uploaded patch set 3 07/18/19, 14:33

  9. TYPO3com voted on patch set 3 V +1 07/18/19, 14:43 Completed build in 10m 02s on Thu, 18 Jul, 04:43 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35173

  10. Andreas Kienast commented on patch set 3 07/18/19, 15:03

    TypoScriptFrontendController.php:482 Unresolved

    v11.0

    TypoScriptFrontendController.php:4014 Unresolved

    The patch is not breaking anymore with this fallback in place, is it?
  11. Benni Mack uploaded patch set 4 07/19/19, 06:12

  12. TYPO3com voted on patch set 4 V +1 07/19/19, 06:23 Completed build in 10m 15s on Fri, 19 Jul, 08:23 AM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35179

  13. Benni Mack voted on patch set 4 V +1 CR +1 07/19/19, 06:34

  14. Susi Moog uploaded patch set 5 07/19/19, 07:28

  15. TYPO3com voted on patch set 5 V +1 07/19/19, 07:38 Completed build in 10m 22s on Fri, 19 Jul, 09:38 AM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35186

  16. Benni Mack voted on patch set 5 V +1 CR +1 07/19/19, 07:59

  17. Frank Nägler voted on patch set 5 CR +1 07/19/19, 08:31

  18. Andreas Kienast voted on patch set 5 V +2 CR +2 07/19/19, 08:39

  19. Andreas Kienast merged patch set 6 07/19/19, 08:39