61312[FEATURE] Add TypoScriptAspect to handle TypoScript Context settings
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +2
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/adminpanel/Classes/Modules/TsDebug/TypoScriptWaterfall.php+5 −2
- typo3/sysext/core/Classes/Context/Context.php+4 −0
- typo3/sysext/core/Classes/Context/TypoScriptAspect.php5new+59 −0
- typo3/sysext/core/Classes/TypoScript/TemplateService.php2+15 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88792-ForceTemplateParsingInTSFEAndTemplateServiceHasBeenDeprecated.rstnew+35 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-88792-AddTypoScriptAspectToHandleTypoScriptRenderingContextSettings.rstnew+20 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php3+21 −5
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+12 −0
Review log 2127
Show 12 earlier messages
-
Susi Moog uploaded patch set 1 07/17/19, 16:55
-
TYPO3com voted on patch set 1 V +1 07/17/19, 17:06 Completed build in 10m 25s on Wed, 17 Jul, 07:06 PM Test Summary: 47118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35137
-
Benni Mack commented on patch set 1 07/18/19, 10:27
-
Oliver Klee commented on patch set 1 07/18/19, 10:47
I like this change!TypoScriptAspect.php:55This structure looks a non-idiomatic. Either this should be an if instead of a switch, or the throwing should happen in the default case.TemplateService.php:404We don't need the === true here. The bool cast will already return the same bool. -
Oliver Klee commented on patch set 1 07/18/19, 10:47
TypoScriptAspect.php:55Replya -> a bit -
Susi Moog commented on patch set 1 07/18/19, 11:07
> Patch Set 1: > > (1 comment)TypoScriptAspect.php:55Replythis is basically done as we currently only handle one property but to keep the aspect in line with other aspects it's done this way already. More a consistency with other aspects than an ideal coding standard for this unit thing.TypoScriptFrontendController.php:1900Reply UnresolvedHow? TemplateService cannot access TSFE->forceTemplateParsing and adding this as constructor argument is dirty to me (as it should be handled in context only) -
Oliver Klee commented on patch set 1 07/18/19, 11:20
TypoScriptAspect.php:55ReplyI see. Then let's please move the throw into the default case to make the intent more explicit in the code. -
Susi Moog commented on patch set 1 07/19/19, 08:35
TypoScriptAspect.php:55Reply UnresolvedAgain, that would be a change that should then be done in all aspects. If you take a look at the get method of all other aspects, they are using the same code (with the throw at the end) - if you want, you could adjust all aspects to the default case, however I don't quite see that as important. -
Andreas Kienast uploaded patch set 2 07/19/19, 08:41
-
Susi Moog uploaded patch set 3 07/19/19, 08:44
-
Susi Moog commented on patch set 3 07/19/19, 08:44
TemplateService.php:404ReplyDone -
TYPO3com voted on patch set 2 V -1 07/19/19, 08:54 Completed build in 12m 26s on Fri, 19 Jul, 10:54 AM Test Summary: 4620 of 7721 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35190
-
Andreas Kienast commented on patch set 3 CR -1 07/19/19, 08:58
Will adjust the deprecated property in TSFE -
TYPO3com voted on patch set 3 V -1 07/19/19, 08:59 Completed build in 10m 47s on Fri, 19 Jul, 10:59 AM Test Summary: 4620 of 7721 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35191
-
Andreas Kienast uploaded patch set 4 07/19/19, 09:03
-
TYPO3com voted on patch set 4 V +1 07/19/19, 09:14 Completed build in 11m 12s on Fri, 19 Jul, 11:14 AM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35193
-
Susi Moog commented on patch set 4 07/19/19, 09:16
TypoScriptFrontendController.php:2009Unresolvedthis can now be removed, too as the __set should take care of that. -
Andreas Kienast uploaded patch set 5 07/19/19, 09:19
-
Andreas Kienast voted on patch set 5 V +1 CR +1 07/19/19, 09:20
-
TYPO3com voted on patch set 5 V +1 07/19/19, 09:33 Completed build in 13m 14s on Fri, 19 Jul, 11:33 AM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35194
-
Andreas Kienast uploaded patch set 6 07/19/19, 11:23
-
Andreas Kienast voted on patch set 6 V +1 CR +1 07/19/19, 11:24
-
TYPO3com voted on patch set 6 V +1 07/19/19, 11:39 Completed build in 15m 37s on Fri, 19 Jul, 01:39 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35204
-
Benni Mack voted on patch set 6 CR +2 07/19/19, 11:53
-
Frank Nägler voted on patch set 6 V +1 CR +1 07/19/19, 12:51
-
Andreas Kienast voted on patch set 6 V +2 CR +2 07/19/19, 12:51
-
Andreas Kienast merged patch set 7 07/19/19, 12:51
TypoScriptFrontendController.php:1900