Review main Abandoned

61315[BUGFIX] Prevent PHP warnings in TypoScript expression language

Frank Nägler CR 0 V 0 Easy +44 −0 updated 08/06/19, 08:21

Commit message

This patch adds two new methods to access GET or POST variables
without a PHP warning in case the parameter is not part of the
current request.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 811

  1. Frank Nägler uploaded patch set 1 07/17/19, 19:55

  2. Oliver Klee commented on patch set 1 07/17/19, 19:58

    RequestWrapper.php:47

    Can we please have type declearations for second parameter and the return type? Ditto for the other new methods.
  3. Frank Nägler commented on patch set 1 07/17/19, 20:04

    RequestWrapper.php:47 Reply

    nope, because "mixed" is no type hint ;)
  4. TYPO3com voted on patch set 1 V +1 07/17/19, 20:05 Completed build in 10m 30s on Wed, 17 Jul, 10:05 PM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35146

  5. Oliver Klee commented on patch set 1 07/17/19, 21:11

    RequestWrapper.php:47 Reply Unresolved

    Then please let's have PHPDoc annotations for the parameters and the return type so human readers and static code analysis tools know it's mixed.
  6. Mathias Brodala commented on patch set 1 07/18/19, 06:34

    RequestWrapper.php:47 Unresolved

    Usually "null" is used as fallback default value. Is there a specific reason for "false" instead?
  7. Frank Nägler uploaded patch set 2 08/04/19, 14:35

  8. TYPO3com voted on patch set 2 V -1 08/04/19, 14:46 Completed build in 10m 31s on Sun, 4 Aug, 02:46 PM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35572

  9. TYPO3com voted on patch set 2 V +1 08/05/19, 12:28 Completed build in 22h 03m 03s on Mon, 5 Aug, 12:28 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35572

  10. Frank Nägler voted on patch set 2 CR -1 08/06/19, 07:05

  11. Frank Nägler abandoned the change 08/06/19, 08:21

    no core issue