61315[BUGFIX] Prevent PHP warnings in TypoScript expression language
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 811
-
Frank Nägler uploaded patch set 1 07/17/19, 19:55
-
Oliver Klee commented on patch set 1 07/17/19, 19:58
-
Frank Nägler commented on patch set 1 07/17/19, 20:04
RequestWrapper.php:47Replynope, because "mixed" is no type hint ;) -
TYPO3com voted on patch set 1 V +1 07/17/19, 20:05 Completed build in 10m 30s on Wed, 17 Jul, 10:05 PM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35146
-
Oliver Klee commented on patch set 1 07/17/19, 21:11
RequestWrapper.php:47Reply UnresolvedThen please let's have PHPDoc annotations for the parameters and the return type so human readers and static code analysis tools know it's mixed. -
Mathias Brodala commented on patch set 1 07/18/19, 06:34
RequestWrapper.php:47UnresolvedUsually "null" is used as fallback default value. Is there a specific reason for "false" instead? -
Frank Nägler uploaded patch set 2 08/04/19, 14:35
-
TYPO3com voted on patch set 2 V -1 08/04/19, 14:46 Completed build in 10m 31s on Sun, 4 Aug, 02:46 PM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35572
-
TYPO3com voted on patch set 2 V +1 08/05/19, 12:28 Completed build in 22h 03m 03s on Mon, 5 Aug, 12:28 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35572
-
Frank Nägler voted on patch set 2 CR -1 08/06/19, 07:05
-
Frank Nägler abandoned the change 08/06/19, 08:21
no core issue
RequestWrapper.php:47