61316[TASK] Show command of console commands in backend
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Sybille Peters +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2026
Show 1 earlier messages
-
Georg Ringer uploaded patch set 1 07/18/19, 03:49
-
Georg Ringer commented on patch set 1 07/18/19, 03:49
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 07/18/19, 04:01 Completed build in 12m 26s on Thu, 18 Jul, 06:01 AM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35147
-
Oliver Klee commented on patch set 1 07/18/19, 07:24
ExecuteSchedulableCommandTask.php:98UnresolvedPlease let's have unit tests for this.ExecuteSchedulableCommandTask.php:101I propose we make this a guard clause.ExecuteSchedulableCommandTask.php:104!= -> !== -
Daniel Windloff commented on patch set 1 CR -1 07/18/19, 07:33
On it -
Daniel Windloff uploaded patch set 2 07/18/19, 07:41
-
Daniel Windloff commented on patch set 2 V +1 CR +1 07/18/19, 07:47
Add argument description for type array (example: language:update locales).ExecuteSchedulableCommandTask.php:101ReplyDoneExecuteSchedulableCommandTask.php:104ReplyDone -
TYPO3com voted on patch set 2 V +1 07/18/19, 07:52 Completed build in 10m 56s on Thu, 18 Jul, 09:52 AM Test Summary: 47120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35156
-
Georg Ringer commented on patch set 2 CR -2 07/18/19, 08:12
will add some tests -
Georg Ringer uploaded patch set 3 07/18/19, 08:32
-
Georg Ringer voted on patch set 3 CR 0 07/18/19, 08:32
-
TYPO3com voted on patch set 3 V +1 07/18/19, 08:44 Completed build in 11m 30s on Thu, 18 Jul, 10:44 AM Test Summary: 47134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35159
-
Oliver Klee commented on patch set 3 07/18/19, 09:04
ExecuteSchedulableCommandTaskTest.php:2Unresolvedstrict, pleaseExecuteSchedulableCommandTaskTest.php:28UnresolvedThis can be array[] (in the annotation, not the type declaration).ExecuteSchedulableCommandTaskTest.php:80UnresolvedWe can even use assertSame here to be more strict. -
Georg Ringer uploaded patch set 4 07/18/19, 11:57
-
TYPO3com voted on patch set 4 V +1 07/18/19, 12:08 Completed build in 10m 12s on Thu, 18 Jul, 02:08 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35165
-
Daniel Windloff voted on patch set 4 V +1 CR +1 07/18/19, 12:13
-
Oliver Klee voted on patch set 4 CR +1 07/18/19, 12:40
-
Markus Klein commented on patch set 4 07/18/19, 12:55
ExecuteSchedulableCommandTask.php:108shouldn't there be quotes around the list? a="f bl c" -
Benjamin Franzke commented on patch set 4 V -1 CR -1 07/21/19, 18:50
ExecuteSchedulableCommandTask.php:108Reply UnresolvedActually I think we don't have arrays here, as ExecuteSchedulableCommandAdditionalFieldProvider does not render. The quoting should be is required independet of type, and should be added to $argumentValue as well, if escaping is required. Symfonys ArrayInput already got logic for stringifying, therefore we should use that, instead of crafting our own. That one will add proper escaping (if required). Will upload a patch. -
Benjamin Franzke uploaded patch set 5 07/21/19, 18:51
-
Benjamin Franzke uploaded patch set 6 07/21/19, 18:58
-
TYPO3com voted on patch set 5 V -1 07/21/19, 19:02 Completed build in 11m 39s on Sun, 21 Jul, 09:02 PM Test Summary: 12 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35251
-
TYPO3com voted on patch set 6 V +1 07/21/19, 19:09 Completed build in 10m 31s on Sun, 21 Jul, 09:09 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35252
-
Sybille Peters voted on patch set 6 V +1 07/22/19, 05:24
-
Andreas Kienast voted on patch set 6 V +2 CR +2 07/22/19, 06:39
-
Andreas Kienast merged patch set 7 07/22/19, 06:39