Review main Merged

61316[TASK] Show command of console commands in backend

Georg Ringer CR +2 V +2 Easy +28 −0 updated 07/22/19, 06:39

Commit message

Show the console command and arguments in the backend of symfony commands.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Sybille Peters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2026

Show 1 earlier messages
  1. Georg Ringer uploaded patch set 1 07/18/19, 03:49

  1. Georg Ringer commented on patch set 1 07/18/19, 03:49

    This change is ready for review.
  2. TYPO3com voted on patch set 1 V +1 07/18/19, 04:01 Completed build in 12m 26s on Thu, 18 Jul, 06:01 AM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35147

  3. Oliver Klee commented on patch set 1 07/18/19, 07:24

    ExecuteSchedulableCommandTask.php:98 Unresolved

    Please let's have unit tests for this.

    ExecuteSchedulableCommandTask.php:101

    I propose we make this a guard clause.

    ExecuteSchedulableCommandTask.php:104

    != -> !==
  4. Daniel Windloff commented on patch set 1 CR -1 07/18/19, 07:33

    On it
  5. Daniel Windloff uploaded patch set 2 07/18/19, 07:41

  6. Daniel Windloff commented on patch set 2 V +1 CR +1 07/18/19, 07:47

    Add argument description for type array (example: language:update locales).

    ExecuteSchedulableCommandTask.php:101 Reply

    Done

    ExecuteSchedulableCommandTask.php:104 Reply

    Done
  7. TYPO3com voted on patch set 2 V +1 07/18/19, 07:52 Completed build in 10m 56s on Thu, 18 Jul, 09:52 AM Test Summary: 47120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35156

  8. Georg Ringer commented on patch set 2 CR -2 07/18/19, 08:12

    will add some tests
  9. Georg Ringer uploaded patch set 3 07/18/19, 08:32

  10. Georg Ringer voted on patch set 3 CR 0 07/18/19, 08:32

  11. TYPO3com voted on patch set 3 V +1 07/18/19, 08:44 Completed build in 11m 30s on Thu, 18 Jul, 10:44 AM Test Summary: 47134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35159

  12. Oliver Klee commented on patch set 3 07/18/19, 09:04

    ExecuteSchedulableCommandTaskTest.php:2 Unresolved

    strict, please

    ExecuteSchedulableCommandTaskTest.php:28 Unresolved

    This can be array[] (in the annotation, not the type declaration).

    ExecuteSchedulableCommandTaskTest.php:80 Unresolved

    We can even use assertSame here to be more strict.
  13. Georg Ringer uploaded patch set 4 07/18/19, 11:57

  14. TYPO3com voted on patch set 4 V +1 07/18/19, 12:08 Completed build in 10m 12s on Thu, 18 Jul, 02:08 PM Test Summary: 47201 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35165

  15. Daniel Windloff voted on patch set 4 V +1 CR +1 07/18/19, 12:13

  16. Oliver Klee voted on patch set 4 CR +1 07/18/19, 12:40

  17. Markus Klein commented on patch set 4 07/18/19, 12:55

    ExecuteSchedulableCommandTask.php:108

    shouldn't there be quotes around the list? a="f bl c"
  18. Benjamin Franzke commented on patch set 4 V -1 CR -1 07/21/19, 18:50

    ExecuteSchedulableCommandTask.php:108 Reply Unresolved

    Actually I think we don't have arrays here, as ExecuteSchedulableCommandAdditionalFieldProvider does not render. The quoting should be is required independet of type, and should be added to $argumentValue as well, if escaping is required. Symfonys ArrayInput already got logic for stringifying, therefore we should use that, instead of crafting our own. That one will add proper escaping (if required). Will upload a patch.
  19. Benjamin Franzke uploaded patch set 5 07/21/19, 18:51

  20. Benjamin Franzke uploaded patch set 6 07/21/19, 18:58

  21. TYPO3com voted on patch set 5 V -1 07/21/19, 19:02 Completed build in 11m 39s on Sun, 21 Jul, 09:02 PM Test Summary: 12 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35251

  22. TYPO3com voted on patch set 6 V +1 07/21/19, 19:09 Completed build in 10m 31s on Sun, 21 Jul, 09:09 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35252

  23. Sybille Peters voted on patch set 6 V +1 07/22/19, 05:24

  24. Andreas Kienast voted on patch set 6 V +2 CR +2 07/22/19, 06:39

  25. Andreas Kienast merged patch set 7 07/22/19, 06:39