61317[BUGFIX] Render slug dependent fields in single table view
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Josef Glatz +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Josef Glatz +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2127
Show 2 earlier messages
-
TYPO3com voted on patch set 1 V +1 07/18/19, 06:49 Completed build in 10m 14s on Thu, 18 Jul, 08:49 AM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35151
-
Kevin Appelt commented on patch set 1 CR -1 07/18/19, 07:19
Should work fine with ['subtitle', 'nav_title', 'title'] but i think ['nav_title', 'title'], 'subtitle' does not work. Or am I missing something? Just read the code but have not executed it. -
Georg Ringer commented on patch set 1 07/18/19, 07:37
i tested actually both @kevin -
Markus Klein commented on patch set 1 07/18/19, 12:59
EditDocumentController.php:463Unresolveda bit too many edit checks?EditDocumentController.php:469UnresolvedgeneratorFields -
Kevin Appelt voted on patch set 1 V +1 CR 0 07/19/19, 07:23
-
Georg Ringer uploaded patch set 2 07/31/19, 06:54
-
TYPO3com voted on patch set 2 V +1 07/31/19, 07:10 Completed build in 11m 46s on Wed, 31 Jul, 07:10 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35408
-
Oliver Klee commented on patch set 2 07/31/19, 09:15
EditDocumentController.php:464Unresolved$table can either be the first element or false if the array is empty. Please let's make this explicit by writing $table !== false. -
Georg Ringer uploaded patch set 3 07/31/19, 15:05
-
Oliver Klee commented on patch set 3 07/31/19, 15:07
EditDocumentController.php:461UnresolvedCan me move this new code block to well-named, separate method so (already too long) preInit does not get much longer? -
TYPO3com voted on patch set 3 V +1 07/31/19, 15:15 Completed build in 10m 18s on Wed, 31 Jul, 03:15 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35420
-
Georg Ringer uploaded patch set 4 08/01/19, 05:57
-
Oliver Klee commented on patch set 4 08/01/19, 06:11
EditDocumentController.php:506UnresolvedNice! Now that this is a separate, well-named method, we can make this a guard clause to amek this even more readable. -
TYPO3com voted on patch set 4 V +1 08/01/19, 06:18 Completed build in 14m 06s on Thu, 1 Aug, 06:18 AM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35423
-
Georg Ringer uploaded patch set 5 08/01/19, 06:29
-
TYPO3com voted on patch set 5 V +1 08/01/19, 06:48 Completed build in 17m 33s on Thu, 1 Aug, 06:48 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35424
-
Jörg Bösche voted on patch set 5 CR +1 08/01/19, 08:14
-
Josef Glatz voted on patch set 5 V +1 CR +1 08/02/19, 08:31
-
Anja Leichsenring commented on patch set 5 CR -1 08/02/19, 09:52
EditDocumentController.php:504Unresolvedthis looks strange. Please confirm this is the condition you wanted to write? -
Georg Ringer uploaded patch set 6 08/02/19, 09:58
-
TYPO3com voted on patch set 6 V +1 08/02/19, 10:09 Completed build in 10m 15s on Fri, 2 Aug, 10:09 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35454
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 08/02/19, 11:26
-
Josef Glatz voted on patch set 6 V +1 CR +1 08/02/19, 12:47
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 08/02/19, 12:50
-
Anja Leichsenring merged patch set 7 08/02/19, 12:50