Review main Merged

61317[BUGFIX] Render slug dependent fields in single table view

Georg Ringer CR +2 V +2 Normal +97 −0 updated 08/02/19, 12:50

Commit message

If only the slug field should be rendered in the record list, all fields
which are required to generate the slug are added as well.

This makes it possible to have a simple mass update option for slug fields.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Josef Glatz +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2127

Show 2 earlier messages
  1. Georg Ringer uploaded patch set 1 07/18/19, 06:39

  2. Georg Ringer commented on patch set 1 07/18/19, 06:40

    This change is ready for review.
  1. TYPO3com voted on patch set 1 V +1 07/18/19, 06:49 Completed build in 10m 14s on Thu, 18 Jul, 08:49 AM Test Summary: 47122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35151

  2. Kevin Appelt commented on patch set 1 CR -1 07/18/19, 07:19

    Should work fine with ['subtitle', 'nav_title', 'title'] but i think ['nav_title', 'title'], 'subtitle' does not work. Or am I missing something? Just read the code but have not executed it.
  3. Georg Ringer commented on patch set 1 07/18/19, 07:37

    i tested actually both @kevin
  4. Markus Klein commented on patch set 1 07/18/19, 12:59

    EditDocumentController.php:463 Unresolved

    a bit too many edit checks?

    EditDocumentController.php:469 Unresolved

    generatorFields
  5. Kevin Appelt voted on patch set 1 V +1 CR 0 07/19/19, 07:23

  6. Georg Ringer uploaded patch set 2 07/31/19, 06:54

  7. TYPO3com voted on patch set 2 V +1 07/31/19, 07:10 Completed build in 11m 46s on Wed, 31 Jul, 07:10 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35408

  8. Oliver Klee commented on patch set 2 07/31/19, 09:15

    EditDocumentController.php:464 Unresolved

    $table can either be the first element or false if the array is empty. Please let's make this explicit by writing $table !== false.
  9. Georg Ringer uploaded patch set 3 07/31/19, 15:05

  10. Oliver Klee commented on patch set 3 07/31/19, 15:07

    EditDocumentController.php:461 Unresolved

    Can me move this new code block to well-named, separate method so (already too long) preInit does not get much longer?
  11. TYPO3com voted on patch set 3 V +1 07/31/19, 15:15 Completed build in 10m 18s on Wed, 31 Jul, 03:15 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35420

  12. Georg Ringer uploaded patch set 4 08/01/19, 05:57

  13. Oliver Klee commented on patch set 4 08/01/19, 06:11

    EditDocumentController.php:506 Unresolved

    Nice! Now that this is a separate, well-named method, we can make this a guard clause to amek this even more readable.
  14. TYPO3com voted on patch set 4 V +1 08/01/19, 06:18 Completed build in 14m 06s on Thu, 1 Aug, 06:18 AM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35423

  15. Georg Ringer uploaded patch set 5 08/01/19, 06:29

  16. TYPO3com voted on patch set 5 V +1 08/01/19, 06:48 Completed build in 17m 33s on Thu, 1 Aug, 06:48 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35424

  17. Jörg Bösche voted on patch set 5 CR +1 08/01/19, 08:14

  18. Josef Glatz voted on patch set 5 V +1 CR +1 08/02/19, 08:31

  19. Anja Leichsenring commented on patch set 5 CR -1 08/02/19, 09:52

    EditDocumentController.php:504 Unresolved

    this looks strange. Please confirm this is the condition you wanted to write?
  20. Georg Ringer uploaded patch set 6 08/02/19, 09:58

  21. TYPO3com voted on patch set 6 V +1 08/02/19, 10:09 Completed build in 10m 15s on Fri, 2 Aug, 10:09 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35454

  22. Anja Leichsenring voted on patch set 6 V +1 CR +1 08/02/19, 11:26

  23. Josef Glatz voted on patch set 6 V +1 CR +1 08/02/19, 12:47

  24. Anja Leichsenring voted on patch set 6 V +2 CR +2 08/02/19, 12:50

  25. Anja Leichsenring merged patch set 7 08/02/19, 12:50