61318[BUGFIX] Properly check install tool password in report
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Susi Moog +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1215
-
Mathias Brodala uploaded patch set 1 07/18/19, 09:06
-
Philippe COURT commented on patch set 1 07/18/19, 09:15
Tested is ok -
TYPO3com voted on patch set 1 V +1 07/18/19, 09:16 Completed build in 10m 32s on Thu, 18 Jul, 11:16 AM Test Summary: 47121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35161
-
Susi Moog voted on patch set 1 CR +1 07/18/19, 09:29
-
Mathias Brodala commented on patch set 1 CR -1 07/18/19, 09:45
I will add a log message too. -
Mathias Brodala uploaded patch set 2 07/18/19, 10:13
-
Mathias Brodala commented on patch set 2 07/18/19, 10:16
I went with the least invasive change now to display a clearly visible report message in case of an unsupported hash algorithm. Notice that the message says "Follow the wiki link to fix this issue." but there is no link because this is part of an exception which relies on the default TYPO3 exception handler. To let this make more sense, we'd need to change more places and possibly add more translatable strings which is not really worth it for this rare case IMO. -
Mathias Brodala uploaded patch set 3 07/18/19, 10:16
-
Mathias Brodala commented on patch set 3 07/18/19, 10:17
Updated outdated reference to $GLOBALS['LANG'] -
TYPO3com voted on patch set 2 V +1 07/18/19, 10:25 Completed build in 11m 56s on Thu, 18 Jul, 12:25 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35163
-
TYPO3com voted on patch set 3 V +1 07/18/19, 10:28 Completed build in 11m 07s on Thu, 18 Jul, 12:28 PM Test Summary: 47190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35164
-
Oliver Klee voted on patch set 3 CR +1 07/18/19, 10:43
-
Susi Moog voted on patch set 3 V +1 CR +1 07/19/19, 08:40
-
Benjamin Franzke voted on patch set 3 V +2 CR +2 07/21/19, 23:19
-
Benjamin Franzke merged patch set 4 07/21/19, 23:19