61323[TASK] Remove dependency to TSFE from AdminPanel initialisation
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/adminpanel/Classes/Controller/MainController.php6+16 −6
- typo3/sysext/adminpanel/Classes/Middleware/AdminPanelInitiator.php+1 −1
- typo3/sysext/adminpanel/Classes/ModuleApi/InitializableInterface.php+2 −0
- typo3/sysext/adminpanel/Classes/ModuleApi/RequestEnricherInterface.phpnew+45 −0
- typo3/sysext/adminpanel/Classes/Modules/Debug/Log.php+4 −3
- typo3/sysext/adminpanel/Classes/Modules/TsDebug/TypoScriptWaterfall.php+6 −18
- typo3/sysext/adminpanel/Classes/Modules/CacheModule.php4+14 −15
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+15 −27
- typo3/sysext/adminpanel/Tests/Unit/Fixtures/MainModuleFixture.php+15 −12
- typo3/sysext/adminpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php+2 −7
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php+2 −10
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-88807-AdminPanelInitializableInterfaceHasBeenDeprecated.rst2new+37 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-88807-AdminPanelRequestEnricherInterfaceHasBeenIntroduced.rstnew+25 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+6 −0
Review log 1726
Show 1 earlier messages
-
Susi Moog uploaded patch set 1 07/19/19, 10:16
-
TYPO3com voted on patch set 1 V -1 07/19/19, 10:27 Completed build in 11m 03s on Fri, 19 Jul, 12:27 PM Test Summary: 37289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35200
-
TYPO3com commented on patch set 1 07/19/19, 11:01 Completed build in 56m 04s on Fri, 19 Jul, 01:01 PM Test Summary: 37289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35200
-
TYPO3com commented on patch set 1 07/19/19, 11:54 Completed build in 2h 34m 10s on Fri, 19 Jul, 01:54 PM Test Summary: 37289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35200
-
Susi Moog uploaded patch set 2 07/19/19, 14:58
-
TYPO3com voted on patch set 2 V -1 07/19/19, 14:59 Completed build in 07s on Fri, 19 Jul, 04:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35228
-
Susi Moog uploaded patch set 3 07/19/19, 15:00
-
Susi Moog commented on patch set 3 07/19/19, 15:02
This change is ready for review. -
TYPO3com voted on patch set 3 V -1 07/19/19, 15:12 Completed build in 11m 19s on Fri, 19 Jul, 05:12 PM Test Summary: 37265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35229
-
Susi Moog uploaded patch set 4 07/19/19, 17:17
-
TYPO3com voted on patch set 4 V -1 07/19/19, 17:28 Completed build in 10m 43s on Fri, 19 Jul, 07:28 PM Test Summary: 37265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35233
-
Benjamin Franzke commented on patch set 4 07/19/19, 18:33
Looks like this patch runs into the same PHP 7.2 segmentation fault as https://review.typo3.org/c/Packages/TYPO3.CMS/+/61274 did, prior removing the object-cast of the immutable array in UserAspect. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/61274/8/typo3/sysext/core/Classes/Context/UserAspect.php#55 for the related change and https://review.typo3.org/c/Packages/TYPO3.CMS/+/61274/6//COMMIT_MSG#21 for more information. Would be great to get #61274 merged. Then we can rebase this patch on that one and tests will run. I actually verified locally, that rebasing this patch fixes the problem (which I was able to reproduce). -
Benjamin Franzke rebased onto patch set 5 07/20/19, 13:18
Rebased to fix segmentation fault -
TYPO3com voted on patch set 5 V +1 07/20/19, 13:33 Completed build in 12m 50s on Sat, 20 Jul, 03:33 PM Test Summary: 47157 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35247
-
Benjamin Franzke commented on patch set 5 07/21/19, 17:28
MainController.php:206This looks wrong, the return value $response of the nested initializeModules() is ignored.MainController.php:207I would check for InitializableInterface only if it does not implement RequestEnricherInterface. That way a class may provide support for both, TYPO3 v9 and v10 by implementing both interfaces.MainController.php:209Should be E_USER_DEPRECATEDCacheModule.php:55To actually get rid of the TSFE dependency we should probably use the requests 'routing' attribute (PageArguments::getPageId) here. Would need a new, extended PageSettingsProviderInterface to have the currently processed PSR-7 request available :\ But for now $GLOBALS['TYPO3_REQUEST']->getAttribute('routing')->getPageId() would work as well. -
Benjamin Franzke uploaded patch set 6 07/21/19, 17:28
-
TYPO3com voted on patch set 6 V +1 07/21/19, 17:38 Completed build in 09m 26s on Sun, 21 Jul, 07:38 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35250
-
Benjamin Franzke commented on patch set 6 07/21/19, 17:39
MainController.php:206ReplyDoneMainController.php:207ReplyDoneMainController.php:209ReplyDoneCacheModule.php:55ReplyChanged this to $GLOBALS['TYPO3_REQUEST']->getAttribute('routing')->getPageId() now. Should we go ahead and deprecate PageSettingsProviderInterface in v10? I would like to, but I can't think of a nice name for the replacement (which passes a PSR-7 request to getPageSettings). Maybe PageSettingsRendererInterface? -
Andreas Kienast commented on patch set 6 07/22/19, 06:31
Deprecation-88807-AdminPanelInitializableInterfaceHasBeenDeprecated.rst:25that what? -
Andreas Kienast uploaded patch set 7 07/22/19, 06:34
-
Andreas Kienast voted on patch set 7 V +1 CR +1 07/22/19, 06:34
-
TYPO3com voted on patch set 7 V +1 07/22/19, 06:46 Completed build in 12m 30s on Mon, 22 Jul, 08:46 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35259
-
Susi Moog commented on patch set 7 07/22/19, 06:53
CacheModule.php:55ReplyI'd leave that in this patch at this point. we can deprecate this in a next step (it should be possible to do that backwards-compatible so 10.1 is also possible). Thx for your adjustments! -
Benjamin Franzke voted on patch set 7 V +2 CR +2 07/22/19, 07:01
-
Benjamin Franzke merged patch set 8 07/22/19, 07:01
-
Benjamin Franzke commented on patch set 8 07/22/19, 07:12
CacheModule.php:55ReplyAckDeprecation-88807-AdminPanelInitializableInterfaceHasBeenDeprecated.rst:25ReplyDone