Review main Merged

61327[FEATURE] Add data type in QueryBuilder::set with createNamedParameter

Manuel Selbach CR +2 V +2 Normal +69 −2 updated 09/25/19, 10:16

Commit message

With this change it is possible to define the type of the value if the
createNamedParameter option is set.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Manuel Selbach +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Manuel Selbach +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Manuel Selbach uploaded patch set 1 07/19/19, 12:25

  2. Manuel Selbach wrote 07/19/19, 12:26

    Topic set to persistence
  3. TYPO3com voted on patch set 1 V +1 08/07/19, 17:09 Completed build in 10m 28s on Wed, 7 Aug, 05:09 PM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35632

  4. Anja Leichsenring uploaded patch set 2 09/25/19, 09:42

  5. Frank Nägler voted on patch set 2 CR +1 09/25/19, 09:44

  6. Frank Nägler commented on patch set 2 V +1 CR -1 09/25/19, 09:46

    good and nice patch, but please add an rst file.
  7. Anja Leichsenring uploaded patch set 3 09/25/19, 09:47

  8. Anja Leichsenring commented on patch set 3 09/25/19, 09:48

    > Patch Set 2: Verified+1 Code-Review-1 > > good and nice patch, but please add an rst file. was already doing that :)
  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/25/19, 09:48

  10. TYPO3com voted on patch set 2 V +1 09/25/19, 09:53 Completed build in 11m 40s on Wed, 25 Sep, 09:53 AM Test Summary: 47736 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36792

  11. TYPO3com voted on patch set 3 V +1 09/25/19, 10:03 Completed build in 13m 35s on Wed, 25 Sep, 10:03 AM Test Summary: 47736 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36794

  12. Manuel Selbach voted on patch set 3 V +1 CR +1 09/25/19, 10:09

  13. Frank Nägler voted on patch set 3 V +2 CR +2 09/25/19, 10:15

  14. Frank Nägler merged patch set 4 09/25/19, 10:16