Review main Merged

61329[BUGFIX] Ensure EventDispatcher is available in installtool container

Benjamin Franzke CR +2 V +2 Easy +14 −7 updated 07/22/19, 07:05

Commit message

The Mailer class used by EnvironmentController::mailTestAction()
requires the EventDispatcher to be available. Provide it by
configuring EventDispatcher and ListenerProvider in a ServiceProvider,
which enables usage from the failsafe install-tool container.

Note: Event listeners that are registered using symfony tags
will still be added to the ServiceProvider instantiated ListenerProvider
in non-failsafe mode. The symfony generated factory will look like:

  $this->services['TYPO3\\CMS\\Core\\EventDispatcher\\ListenerProvider'] =
     $instance =
     \TYPO3\CMS\Core\ServiceProvider::getListenerProvider($this);
  $instance
    ->addListener(
      'TYPO3\\CMS\\Core\\Mail\\Event\\AfterMailerInitializationEvent',
      'TYPO3\\CMS\\Core\\Compatibility\\Slot\\PostInitializeMailer',
      NULL
    );

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Benjamin Franzke uploaded patch set 1 07/19/19, 15:08

  2. Benni Mack voted on patch set 1 CR +1 07/19/19, 15:10

  3. Benjamin Franzke uploaded patch set 2 07/19/19, 15:13

    Changed factoryname
  4. TYPO3com voted on patch set 1 V +1 07/19/19, 15:20 Completed build in 12m 02s on Fri, 19 Jul, 05:20 PM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35230

  5. TYPO3com voted on patch set 2 V +1 07/19/19, 15:25 Completed build in 11m 44s on Fri, 19 Jul, 05:25 PM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35231

  6. Benjamin Franzke wrote 07/19/19, 18:47

    Topic set to di
  7. Benjamin Franzke uploaded patch set 3 07/20/19, 13:09

  8. TYPO3com voted on patch set 3 V +1 07/20/19, 13:24 Completed build in 15m 21s on Sat, 20 Jul, 03:24 PM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35245

  9. Mathias Brodala voted on patch set 3 V +1 CR +1 07/22/19, 07:00

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 07/22/19, 07:05

  11. Andreas Kienast merged patch set 4 07/22/19, 07:05