Review main Merged

61331[TASK] Disable autocompletion in Install Tool settings

Guido Schmechel CR +2 V +2 Easy +5 −2 updated 07/22/19, 19:47

Commit message

To prevent unwanted entries, the autocomplete attribute
in the Install tool is added with the `off` property.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 912

  1. Guido Schmechel uploaded patch set 1 07/20/19, 10:54

  2. TYPO3com voted on patch set 1 V +1 07/20/19, 11:05 Completed build in 09m 59s on Sat, 20 Jul, 01:05 PM Test Summary: 47158 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35242

  3. Andreas Kienast commented on patch set 1 V -1 07/22/19, 08:27

    Chrome needs `autocomplete="off"` in the form tag.
  4. Andreas Kienast uploaded patch set 2 07/22/19, 08:27

  5. TYPO3com voted on patch set 2 V +1 07/22/19, 08:38 Completed build in 10m 40s on Mon, 22 Jul, 10:38 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35263

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 07/22/19, 08:40

  7. Oliver Klee voted on patch set 2 CR +1 07/22/19, 14:55

  8. Tymoteusz Motylewski updated the commit message in patch set 3 07/22/19, 19:36

  9. Tymoteusz Motylewski voted on patch set 3 V +1 CR +1 07/22/19, 19:36

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 07/22/19, 19:39

  11. TYPO3com voted on patch set 3 V +1 07/22/19, 19:47 Completed build in 10m 52s on Mon, 22 Jul, 09:47 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35274

  12. Andreas Kienast merged patch set 4 07/22/19, 19:47