Review main Abandoned

61333[WIP][TASK] DatabaseRecordList: Deprecate public where possible * add typehints where possible

Daniel Windloff CR 0 V 0 Hard +296 −202 updated 01/29/20, 21:37

Commit message

* add typehints where possible

Review

  • Code review CR 0
  • Verified V 0

Files 5

Review log 711

  1. Daniel Windloff uploaded patch set 1 07/22/19, 10:45

  2. TYPO3com voted on patch set 1 V -1 07/22/19, 10:45 Completed build in 12s on Mon, 22 Jul, 12:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35264

  3. Daniel Windloff uploaded patch set 2 07/22/19, 14:33

  4. TYPO3com voted on patch set 2 V +1 07/22/19, 14:43 Completed build in 10m 28s on Mon, 22 Jul, 04:43 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35272

  5. Oliver Klee commented on patch set 2 07/22/19, 14:54

    I like both change types in this change request (deprecate some public things, and add type declarations), but highly recommend separating both into separate change requests (to make them more atomic, and to actually have the commit message subject match the type of changes).

    ElementBrowserRecordList.php:77 Unresolved

    Should $row also have the "array" type declaration?
  6. Daniel Windloff uploaded patch set 3 07/23/19, 08:00

  7. TYPO3com voted on patch set 3 V -1 07/23/19, 08:10 Completed build in 09m 57s on Tue, 23 Jul, 10:10 AM Test Summary: 64 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35281

  8. Daniel Windloff uploaded patch set 4 07/29/19, 09:24

  9. Daniel Windloff marked it work in progress 07/29/19, 09:25

  10. TYPO3com voted on patch set 4 V -1 07/29/19, 09:26 Completed build in 02m 04s on Mon, 29 Jul, 11:26 AM Test Summary: 3 of 190 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35354

  11. Daniel Windloff abandoned the change 01/29/20, 21:37

    Changes are abendoned, that where reqired to continue here