Review main Merged

61336[BUGFIX] Use temporary directory for exporting files

Benni Mack CR +2 V +2 Easy +6 −10 updated 07/23/19, 05:57

Commit message

When adding exports into fileadmin, the files
are stored in a temporary folder, which is located
in typo3temp/var/transient/ - this folder does not
need to be accessed via FAL, as it also adds
some issues when this file is not inside the
document root, for this reason, the code is adapted
to work with the native File System directly, and
when moving to fileadmin/user_upload/_temp_/impexp/
then FAL is used again.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 07/22/19, 10:56

  2. Andreas Kienast voted on patch set 1 CR +1 07/22/19, 10:59

  3. TYPO3com voted on patch set 1 V -1 07/22/19, 11:04 Completed build in 28s on Mon, 22 Jul, 01:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35268

  4. Andreas Kienast uploaded patch set 2 07/22/19, 11:06

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 07/22/19, 11:06

  6. TYPO3com voted on patch set 2 V +1 07/22/19, 11:17 Completed build in 10m 16s on Mon, 22 Jul, 01:17 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35269

  7. Tymoteusz Motylewski commented on patch set 2 07/22/19, 19:43

    any hint how to test/reproduce it?
  8. Susi Moog voted on patch set 2 V +2 CR +2 07/23/19, 05:56

  9. Susi Moog merged patch set 3 07/23/19, 05:57