61343[BUGFIX] Set l10n_mode exclude for pages doktype
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1013
-
Daniel Windloff uploaded patch set 1 07/23/19, 13:15
-
TYPO3com voted on patch set 1 V +1 07/23/19, 13:26 Completed build in 10m 52s on Tue, 23 Jul, 03:26 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35293
-
Oliver Klee commented on patch set 1 07/23/19, 15:12
9.5 and 8.7 are not affected? -
Daniel Windloff commented on patch set 1 07/23/19, 16:29
Reply Unresolved
8.7 has pages_language_overlay. 9.5 is also affected, but as the bugfix changes a behavior, that could be (miss-)used, I prefer to change it only in master. -
Ursula Klinger commented on patch set 1 V +1 10/21/19, 18:22
Tested with version 8.7 which is not affected and version 9.5 which is affected the same as 10. I would agree to only changing it on master as this isn't really a bugfix but rather a change in behaviour. This might be a problem in LTS version 9.5. -
Oli Bartsch commented on patch set 1 V -1 10/22/19, 08:48
What is the purpose of this patch, what does it solve (fix)? You just noted "possible configuration issues" in the ticket. Why shouldn't it be possible to change the doktype in a localized record anymore? Could you therefore please add some more information. -
Georg Ringer commented on patch set 1 CR -1 10/23/19, 12:42
Unresolved
BUGFIX -
Daniel Goerz updated the commit message in patch set 2 01/19/20, 11:40
-
TYPO3com voted on patch set 2 V -1 01/19/20, 11:50 Completed build in 10m 12s on Sun, 19 Jan, 11:50 AM Test Summary: 69857 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40083
-
TYPO3com voted on patch set 2 V +1 01/19/20, 11:57 Completed build in 27m 03s on Sun, 19 Jan, 11:57 AM Test Summary: 70442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40083
-
Benni Mack commented on patch set 2 01/27/20, 16:19
I ran into a similar issue with tt_content recently, and I believe we should make a decision on having 'type' field non-changeable by default. For pages however this gets tricky, we also might need to get an upgrade wizard going to ensure that all translated records have the same type as the default. -
Benni Mack commented on patch set 2 02/27/20, 11:37
Thinking about this a bit more, I think this cannot be done by core right now, this would currently restrict features that is currently possible. AllowLanguageSynchronization would be more appropriate, but still an upgrade wizard would also be missing. -
Benni Mack abandoned the change 03/06/20, 19:47
I'll abandon this for the time being, as I think this needs a different concept.