Review main Merged

61345[BUGFIX] Explicitly cast variable to string

Alexander Schnitzler CR +2 V +2 Easy +7 −1 updated 07/29/19, 18:47

Commit message

Class \TYPO3\CMS\Extbase\Core\Bootstrap calls method
\TYPO3\CMS\Extbase\Mvc\ResponseInterface::shutdown()
which does not declare a strict return type yet.

Thus, it's possible that the returned value is not
of type string which then violates the return type
promise of method handleRequest() of the Bootstrap
class.

Therefore, the return value is explicitly casted
to string.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Armin Vieweg +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Alexander Schnitzler uploaded patch set 1 07/24/19, 07:52

  2. TYPO3com voted on patch set 1 V +1 07/24/19, 08:02 Completed build in 09m 55s on Wed, 24 Jul, 10:02 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35302

  3. Alexander Schnitzler updated the commit message in patch set 2 07/28/19, 11:15

  4. Alexander Schnitzler updated the commit message in patch set 3 07/28/19, 11:16

  5. TYPO3com voted on patch set 2 V +1 07/28/19, 11:27 Completed build in 11m 33s on Sun, 28 Jul, 01:27 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35348

  6. TYPO3com voted on patch set 3 V +1 07/28/19, 11:29 Completed build in 12m 26s on Sun, 28 Jul, 01:29 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35349

  7. Armin Vieweg voted on patch set 3 CR +1 07/29/19, 15:37

  8. Oliver Klee voted on patch set 3 CR +1 07/29/19, 18:44

  9. Andreas Kienast voted on patch set 3 CR +1 07/29/19, 18:45

  10. Georg Ringer voted on patch set 3 V +1 CR +1 07/29/19, 18:45

  11. Benni Mack voted on patch set 3 V +2 CR +2 07/29/19, 18:47

  12. Benni Mack merged patch set 4 07/29/19, 18:47