Review main Merged

61346[BUGFIX] Streamline routing redirects to default site language

Oliver Hader CR +2 V +2 Easy +15 −15 updated 08/02/19, 12:03

Commit message

Calling the frontend with an URL that does not contain a valid base
URI for a configured language resulted in a temporary redirect (307)
to the base URI of the default language. In order to allow detecting
outdated links returning a page not found (404) is used.

Example: https://example.org/en/ is the base URI of a valid language
+ https://example.org/ -> redirects to default language /en/ (307)
+ https://example.org/nothing/ -> responds a page not found  (404)

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Chris Müller +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Chris Müller +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Oliver Hader uploaded patch set 1 07/24/19, 09:33

  2. Oliver Hader commented on patch set 1 07/24/19, 09:36

    SiteBaseRedirectResolver.php:53

    not sure what the default should be - either the redirect or 404-error (currently)
  3. TYPO3com voted on patch set 1 V -1 07/24/19, 09:43 Completed build in 10m 21s on Wed, 24 Jul, 11:43 AM Test Summary: 9 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35303

  4. Oliver Hader uploaded patch set 2 07/24/19, 10:00

  5. TYPO3com voted on patch set 2 V +1 07/24/19, 10:11 Completed build in 10m 52s on Wed, 24 Jul, 12:11 PM Test Summary: 47163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35304

  6. Johannes Seipelt commented on patch set 2 07/24/19, 20:57

    SiteBaseRedirectResolver.php:53 Reply

    there is also an issue regarding redirects with no language key https://forge.typo3.org/issues/87455 might be relevant too.
  7. Oliver Hader updated the commit message in patch set 3 07/25/19, 11:46

  8. Oliver Hader commented on patch set 3 07/25/19, 11:46

    This change is ready for review.
  9. Oliver Hader commented on patch set 3 07/25/19, 11:50

    > Patch Set 2: > > (1 comment)

    SiteBaseRedirectResolver.php:53 Reply Unresolved

    If it's about redirect being defined using the according backend module (ext:redirects) then this should be related to this change - as mentioned in forge ticket, redirects middleware should have been processed earlier.
  10. TYPO3com voted on patch set 3 V +1 07/25/19, 11:56 Completed build in 10m 29s on Thu, 25 Jul, 01:56 PM Test Summary: 47163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35321

  11. Chris Müller voted on patch set 3 V +1 CR +1 07/26/19, 14:10

  12. Anja Leichsenring voted on patch set 3 V +2 CR +2 08/02/19, 12:03

  13. Anja Leichsenring merged patch set 4 08/02/19, 12:03