61348[BUGFIX] Show real directory name in flash message after renaming
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Frank Nägler +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1621
-
Daniel Windloff uploaded patch set 1 07/24/19, 12:48
-
Mathias Brodala updated the commit message in patch set 2 07/24/19, 12:50
-
Daniel Windloff uploaded patch set 3 07/24/19, 12:50
-
Mathias Brodala commented on patch set 3 CR -1 07/24/19, 12:51
-
Daniel Windloff updated the commit message in patch set 4 07/24/19, 12:52
-
Daniel Windloff uploaded patch set 5 07/24/19, 12:54
-
Daniel Windloff commented on patch set 5 07/24/19, 12:55
fileMessages.xlf:49ReplyDone -
TYPO3com voted on patch set 1 V +1 07/24/19, 13:01 Completed build in 13m 22s on Wed, 24 Jul, 03:01 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35308
-
TYPO3com voted on patch set 2 V +1 07/24/19, 13:03 Completed build in 12m 51s on Wed, 24 Jul, 03:03 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35309
-
TYPO3com voted on patch set 3 V +1 07/24/19, 13:12 Completed build in 21m 54s on Wed, 24 Jul, 03:12 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35310
-
TYPO3com voted on patch set 4 V +1 07/24/19, 13:13 Completed build in 13m 22s on Wed, 24 Jul, 03:13 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35311
-
TYPO3com voted on patch set 5 V +1 07/24/19, 13:17 Completed build in 17m 14s on Wed, 24 Jul, 03:17 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35312
-
Oliver Klee commented on patch set 5 07/24/19, 16:55
ExtendedFileUtility.php:870Do we need hsc on the file name/folder, or are they htmlspecialchared automatically? -
Daniel Windloff commented on patch set 5 07/25/19, 08:50
ExtendedFileUtility.php:870ReplyAs far as I know the folder name is processed through sanitizeFileName. The method has the following description: "Returns a string where any character not matching [.a-zA-Z0-9_-] is substituted by '_' Trailing dots are removed" As far as I know with [.a-zA-Z0-9_-] as allowed char it is not needed to add hsc. -
Frank Nägler voted on patch set 5 CR +1 08/06/19, 14:12
-
Andreas Kienast commented on patch set 5 CR +1 08/06/19, 15:02
ExtendedFileUtility.php:870ReplyFlash messages are hsc'd on output automatically -
Oliver Klee voted on patch set 5 CR +1 08/06/19, 15:12
-
Frank Nägler voted on patch set 5 V +1 08/07/19, 07:21
-
Frank Nägler voted on patch set 5 V +2 CR +2 08/07/19, 07:24
-
Andreas Kienast voted on patch set 5 V +1 08/07/19, 07:25
-
Frank Nägler merged patch set 6 08/07/19, 07:27
fileMessages.xlf:49