Review 9.5 Merged

61352[BUGFIX] Use temporary directory for exporting files

Susi Moog CR +2 V +2 Easy +5 −5 updated 07/23/19, 09:54

Commit message

When adding exports into fileadmin, the files
are stored in a temporary folder, which is located
in typo3temp/var/transient/ - this folder does not
need to be accessed via FAL, as it also adds
some issues when this file is not inside the
document root, for this reason, the code is adapted
to work with the native File System directly, and
when moving to fileadmin/user_upload/_temp_/impexp/
then FAL is used again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. Susi Moog commented on patch set 1 07/23/19, 05:58

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/impexp/Classes/Controller/ExportController.php
  2. TYPO3com voted on patch set 1 V -1 07/23/19, 05:58 Completed build in 11s on Tue, 23 Jul, 07:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-918

  3. Susi Moog uploaded patch set 2 07/23/19, 06:00

  4. TYPO3com commented on patch set 2 07/23/19, 06:00 Completed build in 22s on Tue, 23 Jul, 08:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-919

  5. Susi Moog uploaded patch set 3 07/23/19, 06:04

  6. Susi Moog commented on patch set 3 07/23/19, 06:05

    This change is ready for review.
  7. TYPO3com voted on patch set 3 V +1 07/23/19, 06:18 Completed build in 13m 53s on Tue, 23 Jul, 08:18 AM Test Summary: 50513 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-920

  8. Benni Mack voted on patch set 3 V +2 CR +2 07/23/19, 09:54

  9. Benni Mack merged patch set 4 07/23/19, 09:54