Review 9.5 Merged

61356[BUGFIX] Streamline routing redirects to default site language

Anja Leichsenring CR +2 V +2 Easy +15 −15 updated 08/02/19, 12:47

Commit message

Calling the frontend with an URL that does not contain a valid base
URI for a configured language resulted in a temporary redirect (307)
to the base URI of the default language. In order to allow detecting
outdated links returning a page not found (404) is used.

Example: https://example.org/en/ is the base URI of a valid language
+ https://example.org/ -> redirects to default language /en/ (307)
+ https://example.org/nothing/ -> responds a page not found  (404)

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 35

  1. Anja Leichsenring commented on patch set 1 08/02/19, 12:04

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/02/19, 12:17 Completed build in 13m 02s on Fri, 2 Aug, 12:17 PM Test Summary: 9 of 50985 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-931

  3. TYPO3com voted on patch set 1 V +1 08/02/19, 12:45 Completed build in 53m 45s on Fri, 2 Aug, 12:45 PM Test Summary: 50517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-931

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/02/19, 12:47

  5. Anja Leichsenring merged patch set 2 08/02/19, 12:47