Review 9.5 Merged

61360[BUGFIX] Render tags of documentation changelog deferred

Anja Leichsenring CR +2 V +2 Easy +13 −11 updated 08/02/19, 15:25

Commit message

Currently, when the changelogs get rendered in the Install Tool, for each
document the tags get rendered in the document itself, which has a huge
negative impact on rendering performance.

This patch changes the rendering to the triggered deferred, when the
document is opened.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 58

  1. Anja Leichsenring commented on patch set 1 08/02/19, 13:50

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/UpgradeDocs.ts * typo3/sysext/install/Resources/Private/Partials/Upgrade/UpgradeDocs/PanelItem.html * typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/UpgradeDocs.js
  2. TYPO3com voted on patch set 1 V +1 08/02/19, 14:06 Completed build in 14m 36s on Fri, 2 Aug, 02:06 PM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-938

  3. Andreas Kienast uploaded patch set 2 08/02/19, 14:27

  4. TYPO3com voted on patch set 2 V -1 08/02/19, 14:41 Completed build in 13m 38s on Fri, 2 Aug, 02:41 PM Test Summary: 2 of 50997 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-939

  5. TYPO3com voted on patch set 2 V +1 08/02/19, 14:58 Completed build in 44m 20s on Fri, 2 Aug, 02:58 PM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-939

  6. Anja Leichsenring commented on patch set 2 08/02/19, 15:09

    This change is ready for review.
  7. Andreas Kienast voted on patch set 2 V +2 CR +2 08/02/19, 15:25

  8. Andreas Kienast merged patch set 3 08/02/19, 15:25