Review 9.5 Merged

61365[BUGFIX] Removes cropping from pagetree title

Georg Ringer CR +2 V +2 Easy +0 −1 updated 08/05/19, 13:00

Commit message

Pagetree uses javascript for search.
Cropping causes issues because not the full title
is searched. As the pagetree is neither scrollable
nor resizable, cropping does not make sense anyway
and is therefor removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 59

  1. Georg Ringer commented on patch set 1 08/03/19, 13:31

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 08/03/19, 13:44 Completed build in 13m 18s on Sat, 3 Aug, 01:44 PM Test Summary: 9 of 50997 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-952

  3. TYPO3com commented on patch set 1 08/05/19, 04:33 Completed build in 14m 36s on Mon, 5 Aug, 04:33 AM Test Summary: 2 of 50997 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-958

  4. TYPO3com voted on patch set 1 V +1 08/05/19, 12:02 Completed build in 7h 58m 08s on Mon, 5 Aug, 12:02 PM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-958

  5. Frank Nägler commented on patch set 1 V +1 CR +1 08/05/19, 12:24

    I can not confirm, that the fix works with 9.5 Longer titles will be cut and gets "..." appended. Double click to edit the title in the tree shows also the dots at the end.
  6. Andreas Kienast voted on patch set 1 V +2 CR +2 08/05/19, 12:32

  7. Frank Nägler commented on patch set 1 08/05/19, 12:35

    > Patch Set 1: Verified+1 Code-Review+1 > > I can not confirm, that the fix works with 9.5 > Longer titles will be cut and gets "..." appended. > Double click to edit the title in the tree shows also the dots at the end. stupid gerrit, works well... "not my message" ;)
  8. Andreas Kienast merged patch set 2 08/05/19, 12:35

  9. TYPO3com commented on patch set 1 08/05/19, 13:00 Completed build in 23h 42m 24s on Mon, 5 Aug, 01:00 PM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-952