Review 9.5 Merged

61371[BUGFIX] Support multiple order by fields in PageRepository

Frank Nägler CR +2 V +2 Easy +1 −1 updated 08/06/19, 12:49

Commit message

The method PageRepository::getSubpagesForPages allows an arbitrary
number of orderBy fields, though the way it is passed to the
query builder, only the last field is used.

This patch simply changes the DBAL call to ->addOrderBy to ensure
all set order by fields are used, in the order they are defined.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Frank Nägler commented on patch set 1 08/06/19, 12:28

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Classes/Domain/Repository/PageRepository.php
  2. TYPO3com voted on patch set 1 V -1 08/06/19, 12:29 Completed build in 14s on Tue, 6 Aug, 12:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-974

  3. Frank Nägler uploaded patch set 2 08/06/19, 12:34

  4. Frank Nägler commented on patch set 2 08/06/19, 12:36

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 08/06/19, 12:48 Completed build in 14m 22s on Tue, 6 Aug, 12:48 PM Test Summary: 50529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-975

  6. Frank Nägler voted on patch set 2 V +2 CR +2 08/06/19, 12:49

  7. Frank Nägler merged patch set 3 08/06/19, 12:49