Review main Abandoned

61372[BUGFIX] Show language information in record list only if languages available

Georg Ringer CR 0 V 0 Normal +64 −0 updated 11/10/21, 18:34

Commit message

Improve the usability by hiding the language columns and information if
only one language is defined for the site.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1625

  1. Georg Ringer uploaded patch set 1 07/25/19, 11:36

  2. Georg Ringer commented on patch set 1 07/25/19, 11:36

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 07/25/19, 11:36 Completed build in 13s on Thu, 25 Jul, 01:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35319

  4. Georg Ringer uploaded patch set 2 07/25/19, 11:40

  5. TYPO3com voted on patch set 2 V -1 07/25/19, 11:51 Completed build in 10m 55s on Thu, 25 Jul, 01:51 PM Test Summary: 1 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35320

  6. Daniel Windloff commented on patch set 2 07/25/19, 12:49

    DatabaseRecordList.php:4123 Unresolved

    Could be removed; is in catch

    DatabaseRecordList.php:4125 Unresolved

    :array

    DatabaseRecordList.php:4132 Unresolved

    Use $this->getBackendUserAuthentication() instead
  7. Georg Ringer uploaded patch set 3 07/31/19, 06:51

  8. TYPO3com voted on patch set 3 V -1 07/31/19, 07:06 Completed build in 12m 56s on Wed, 31 Jul, 07:06 AM Test Summary: 1 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35407

  9. Georg Tiefenbrunn commented on patch set 3 CR -1 08/01/19, 13:49

    DatabaseRecordList.php:784 Unresolved

    SiteNotFoundException is never thrown in try block. NullSite::languages isn't initialized as array (see https://github.com/TYPO3/TYPO3.CMS/blob/9.5/typo3/sysext/core/Classes/Site/Entity/NullSite.php#L40) and NullSite::getAvailableLanguages() doesn't check if $this->languages is an array (see https://github.com/TYPO3/TYPO3.CMS/blob/9.5/typo3/sysext/core/Classes/Site/Entity/NullSite.php#L149). Imho that's a bug which should be fixed in NullSite::class (both initialize ``protected $languages = [];`` and ``foreach ($this->languages ?? [] as $language)``).
  10. Georg Ringer rebased onto patch set 4 03/07/20, 20:25

  11. Georg Ringer uploaded patch set 5 03/07/20, 20:33

  12. TYPO3com voted on patch set 4 V -1 03/07/20, 20:43 Completed build in 17m 04s on Sat, 7 Mar, 08:43 PM Test Summary: 1 of 72577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1101

  13. TYPO3com voted on patch set 5 V -1 03/07/20, 20:46 Completed build in 12m 36s on Sat, 7 Mar, 08:46 PM Test Summary: 1 of 72577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1102

  14. Georg Ringer rebased onto patch set 6 04/15/20, 10:03

  15. TYPO3com voted on patch set 6 V -1 04/15/20, 10:48 Completed build in 37m 38s on Wed, 15 Apr, 10:48 AM Test Summary: 1 of 74007 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2566

  16. Georg Ringer uploaded patch set 7 04/15/20, 11:40

  17. TYPO3com voted on patch set 7 V +1 04/15/20, 11:54 Completed build in 13m 48s on Wed, 15 Apr, 11:54 AM Test Summary: 73523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2571

  18. Georg Ringer uploaded patch set 8 04/15/20, 12:40

  19. Oliver Klee commented on patch set 8 04/15/20, 12:43

    BackendCoreEnvironment.php:99 Unresolved

    No abbreviations, please (qb). I propose $query or $queryBuilder.
  20. TYPO3com voted on patch set 8 V -1 04/15/20, 13:06 Completed build in 01m 35s on Wed, 15 Apr, 01:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2577

  21. Benjamin Franzke commented on patch set 8 05/02/20, 16:40

    BackendCoreEnvironment.php:105 Unresolved

    Please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/64386 — should better be: GeneralUtility::makeInstance(SiteConfiguration::class), without constructor argument. But yes, we'll need the constructor argument for the 9.5 backport.
  22. Benni Mack updated the commit message in patch set 9 05/25/20, 18:50

  23. TYPO3com voted on patch set 9 V -1 05/25/20, 19:56 Completed build in 25m 24s on Mon, 25 May, 07:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3543

  24. Benni Mack commented on patch set 9 11/10/21, 17:28

    I think this issue is now resolved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/70403
  25. Benni Mack abandoned the change 11/10/21, 18:34

    abandoned after discussion with Georg