Review main Merged

61373[BUGFIX] Ensure ReflectionService can be used during TCA load

Benjamin Franzke CR +2 V +2 Easy +11 −8 updated 08/30/19, 11:43

Commit message

In order to support the 'tcaIsBeingBuilt' for legacy signal
listeners that are *not* available in the symfony container,
we need to enable the Extbase Object Container to use the
(lazy loaded) ReflectionService, which requires the CacheManager
to be available.
Therefore we now mark "boot.state" done once ext_localconf.php
has been loaded. boot.state = true will allow the CacheManager
to be created in TYPO3\CMS\Core\ServiceProvider instead of
throwing a LogicException.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Benjamin Franzke uploaded patch set 1 07/25/19, 15:23

  2. TYPO3com voted on patch set 1 V +1 07/25/19, 15:35 Completed build in 11m 25s on Thu, 25 Jul, 05:35 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35326

  3. Oliver Klee commented on patch set 1 07/25/19, 16:01

    Bootstrap.php:149

    Now that we have an "else" branch, I propose reversing the condition to reduce the cognitive load for reading this part of the code?
  4. Benjamin Franzke wrote 08/03/19, 20:25

    Topic set to di
  5. Susi Moog voted on patch set 1 CR +1 08/04/19, 08:27

  6. Anja Leichsenring commented on patch set 1 08/25/19, 11:37

    Bootstrap.php:148

    I don't get this. The bootState->done is set to true in both cases, so why the else clause?
  7. Benjamin Franzke commented on patch set 1 08/26/19, 07:11

    Bootstrap.php:148 Reply

    It needs to be set in both cases, true – but I want it to be now need to set it before TCA loading, to allow CacheManager usage in TCA related hooks. Previously bootState->done = true came to late for non-failsafe cases.

    Bootstrap.php:149 Reply

    Well, the non failsafe case is the most important one, so reversing would make it actually harder to grasp the important part. Anyway, to ease reading I will refactor to an early return, eliminating the need for an else-branch.
  8. Benjamin Franzke uploaded patch set 2 08/26/19, 07:11

  9. TYPO3com voted on patch set 2 V +1 08/26/19, 07:20 Completed build in 09m 08s on Mon, 26 Aug, 07:20 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35836

  10. Andreas Kienast voted on patch set 2 CR +1 08/26/19, 08:11

  11. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/30/19, 11:41

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 08/30/19, 11:43

  13. Andreas Kienast merged patch set 3 08/30/19, 11:43