61373[BUGFIX] Ensure ReflectionService can be used during TCA load
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1113
-
Benjamin Franzke uploaded patch set 1 07/25/19, 15:23
-
TYPO3com voted on patch set 1 V +1 07/25/19, 15:35 Completed build in 11m 25s on Thu, 25 Jul, 05:35 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35326
-
Oliver Klee commented on patch set 1 07/25/19, 16:01
-
Benjamin Franzke wrote 08/03/19, 20:25
Topic set to di -
Susi Moog voted on patch set 1 CR +1 08/04/19, 08:27
-
Anja Leichsenring commented on patch set 1 08/25/19, 11:37
Bootstrap.php:148I don't get this. The bootState->done is set to true in both cases, so why the else clause? -
Benjamin Franzke commented on patch set 1 08/26/19, 07:11
Bootstrap.php:148ReplyIt needs to be set in both cases, true – but I want it to be now need to set it before TCA loading, to allow CacheManager usage in TCA related hooks. Previously bootState->done = true came to late for non-failsafe cases.Bootstrap.php:149ReplyWell, the non failsafe case is the most important one, so reversing would make it actually harder to grasp the important part. Anyway, to ease reading I will refactor to an early return, eliminating the need for an else-branch. -
Benjamin Franzke uploaded patch set 2 08/26/19, 07:11
-
TYPO3com voted on patch set 2 V +1 08/26/19, 07:20 Completed build in 09m 08s on Mon, 26 Aug, 07:20 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35836
-
Andreas Kienast voted on patch set 2 CR +1 08/26/19, 08:11
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 08/30/19, 11:41
-
Andreas Kienast voted on patch set 2 V +2 CR +2 08/30/19, 11:43
-
Andreas Kienast merged patch set 3 08/30/19, 11:43
Bootstrap.php:149