61375[BUGFIX] Make sure the baseVariants are respected
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- Daniel Maier +1
-
Verified V +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1417
-
Guido Schmechel uploaded patch set 1 07/26/19, 10:18
-
TYPO3com voted on patch set 1 V +1 07/26/19, 10:29 Completed build in 10m 38s on Fri, 26 Jul, 12:29 PM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35331
-
Oliver Klee commented on patch set 1 07/26/19, 10:30
-
Guido Schmechel commented on patch set 1 07/26/19, 10:32
Support for the test is needed here. In the unit tests you can quickly copy an existing test. But then several new things are needed (CacheManager, ExpressionBuilder etc.) I miss the experience there. -
Guido Schmechel voted on patch set 1 CR -1 07/26/19, 10:57
-
Guido Schmechel uploaded patch set 2 07/26/19, 11:12
-
TYPO3com voted on patch set 2 V -1 07/26/19, 11:23 Completed build in 10m 35s on Fri, 26 Jul, 01:23 PM Test Summary: 4 of 47523 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35332
-
Guido Schmechel uploaded patch set 3 07/26/19, 11:25
-
TYPO3com voted on patch set 3 V +1 07/26/19, 11:35 Completed build in 10m 38s on Fri, 26 Jul, 01:35 PM Test Summary: 47164 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35333
-
Andreas Kienast voted on patch set 3 CR +1 07/26/19, 11:50
-
Daniel Maier voted on patch set 3 CR +1 08/02/19, 19:57
-
Frank Nägler commented on patch set 3 CR -1 08/07/19, 12:06
temporary -1, please check my comment in the codeContentObjectRenderer.php:4714I did not find any documentation about the key "site", but "siteLanguage" (see next case block). The documentation say siteLanguage:base should work. I am not sure about this change, because from my point of view the base should be resolved by siteLanuage instead of site. So I think we don't have a bug here, only a wrong configuration (or a missing documentation) -
Guido Schmechel commented on patch set 3 08/07/19, 12:20
ContentObjectRenderer.php:4714Reply UnresolvedHi Frank, i will have a look with languages. But in this documentation there is the mentioned example from the issue: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/SiteHandling/UseSiteInTypoScript.html -
Frank Nägler commented on patch set 3 CR 0 08/07/19, 12:36
ok, it looks like the documentation is missing here. Also resolving the base per site is a valid use case. -
Frank Nägler voted on patch set 3 V +1 CR +1 08/08/19, 08:32
-
Andreas Kienast voted on patch set 3 V +2 CR +2 08/08/19, 11:43
-
Andreas Kienast merged patch set 4 08/08/19, 11:43
ContentObjectRenderer.php:4715Unresolved